1061621 - [Settings]In create screen lock passcode, passcode doesn't matched.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[dongkyu lee]

1. Title : In create screen lock passcode, passcode doesn't matched.
2. Precondition : nothing.
3. Tester's Action : 
    a. Run Settings app
    b. Enter Screen lock menu 
    c. Turn Lock Screen on
    d. Turn Passcode lock on
    e. Fill Create a Passcode/Confirm a Passcode properly.
    f. Press home button and run settings app Or Power key press twice.
    g. Press create button.
    h. Passcode doesn't match. Try again. message appeared. 
4. Detailed Symptom : Can't create passcode.
5. Expected : passcode is created
6. Reproducibility: Y
1) Frequency Rate : 100%
7. Gaia Master :
8. Gaia Revision : 2014-07-12. ca022f81

Comment 1

[Vance Chen [:vchen][skype:vance.lucida][[e-mail]]]

Hi Evelyn -

Could you have someone to take a look at this one? Please let me know if you have any problem reproducing this issue

Thanks

Vance

Comment 2

[Evelyn Hung]

it's an interesting bug. I will take a look.

Comment 3

[Evelyn Hung]

So the problem is when Settings is bring up from background, |onBeforeShow()| will be called, and then the "success" status on the panel is cleared.

https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/panels/screen_lock_passcode/screen_lock_passcode.js#L78

EJ will help on providing a patch. Thank you, EJ.

Comment 4

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch on master

Arthur, can you help me check this patch ? This is all about the timing to call onBeforeShow/onShow/onBeforeHide/onHide.

For bug 1061621, I think the problem is quite similar and I decided to fix it at the same time in this patch.

Comment 5

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

(In reply to EJ Chen [:eragonj][:小龍哥] from comment #4)
> For bug 1061621, I think the problem is quite similar and I decided to fix

typo, should be bug 1037640 instead.

> it at the same time in this patch.

Comment 6

[Rachelle Yang [:ryang][[e-mail]]]

Hi Arthur, could you please kindly help us review the patch on comment4 ? Thank you very much.

Comment 7

[Vance Chen [:vchen][skype:vance.lucida][[e-mail]]]

Hi Evelyn -

Arthur probably is not available these days, do you think you can find someone else from your team to review this one?

Thanks

Vance

Comment 8

[Arthur Chen [:arthurcc][inactive after 6/30]]

I'm back from my PTO. Checking the patch.

Comment 9

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8490626 [details] [review]
patch on master

r=me. Please set bug 1037640 as a duplicate of this one as the patch also solve it. Thanks!

Comment 11

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks all, this patch was merged into Gaia/master(2.2) : https://github.com/mozilla-b2g/gaia/commit/03129c6389365e0648d1dfd7fe5a44ccce4c744b

Comment 12

[dongkyu lee]

Thank you all.
Would you please merge this patch to Gaia/2.0.

Comment 13

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

(In reply to dongkyu lee from comment #12)
> Thank you all.
> Would you please merge this patch to Gaia/2.0.

I think it's too late to land this on 2.0 (Because we are already after CC) but I can still try to make it in 2.1.

Comment 14

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

[Blocking Requested - why for this release]:

Based on comment 0, users are unable to set passcode after specific operations and can be reproduced with 100% frequency rate.

Comment 15

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8490626 [details] [review]
patch on master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: users are unable to set passcode after specific operations and can be reproduced with 100% frequency rate.
[Testing completed]: yes
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]: no

Comment 16

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/0d31cf459257153aa7438792ba1081bc0cb817b3

Comment 17

[Roland Kunkel [:RolandK]]

This issue is verified as fixed for latest 2.1 Flame build:

Environmental Variables:
------------------------
Device: Flame 2.1
BuildID: 20141012001201
Gaia: d18e130216cd3960cd327179364d9f71e42debda
Gecko: 610ee0e6a776
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Environmental Variables:
----------------------------------------
Device: Flame 2.2 Master
BuildID: 20141012040203
Gaia: 717ad4e8b7fc10ab8248500d00ba5ba0977fa8ab
Gecko: 44168a7af20d
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Following the STRs in comment 0, when pressing the home button or the power button twice before hitting the 'create' option does NOT result in an error that the passcode doesn't match and the passcode is created.