Closed
Bug 1061664
Opened 10 years ago
Closed 10 years ago
Build: reduce number of build warnings in opt builds
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: bbouvier, Assigned: bbouvier)
References
Details
Attachments
(2 files)
9.25 KB,
patch
|
till
:
review+
|
Details | Diff | Splinter Review |
1019 bytes,
patch
|
till
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
A few DebugOnly<> variables and #ifdef DEBUG functions. Also removed unused
variables in TypedArrayObject.cpp (try build coming soon).
Attachment #8482717 -
Flags: review?(till)
Assignee | ||
Comment 2•10 years ago
|
||
This one might not be of interest, or could be implemented differently. It
kills the warning that the return value of read() is unused. We could either do
this, or crash if the return value of read(/udev/random) isn't the expected
length.
Attachment #8482718 -
Flags: review?(till)
Comment 3•10 years ago
|
||
Comment on attachment 8482717 [details] [diff] [review]
Make a few variables and functions debug-only in /js
Review of attachment 8482717 [details] [diff] [review]:
-----------------------------------------------------------------
Nice, thank you for doing this!
Attachment #8482717 -
Flags: review?(till) → review+
Comment 4•10 years ago
|
||
Comment on attachment 8482718 [details] [diff] [review]
Ignore return value of read() in jsmath.cpp
Review of attachment 8482718 [details] [diff] [review]:
-----------------------------------------------------------------
Yeah, I think this is fine. It certainly doesn't make the situation worse, and looking at this code any longer than I have to isn't good for my sanity.
Attachment #8482718 -
Flags: review?(till) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Thanks, try builds here:
https://tbpl.mozilla.org/?tree=Try&rev=dbe338475118
Assignee | ||
Comment 6•10 years ago
|
||
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/47bdae7e0574
https://hg.mozilla.org/mozilla-central/rev/7a91c0ac0c75
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Updated•10 years ago
|
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•