[Browser] Blurry and Misaligned SSL Lock

RESOLVED FIXED in Firefox OS v2.1

Status

Firefox OS
Gaia::System::Browser Chrome
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: epang, Assigned: kgrandon)

Tracking

unspecified
2.1 S4 (12sep)
x86
Gonk (Firefox OS)

Firefox Tracking Flags

(b2g-v2.0 unaffected, b2g-v2.1 fixed, b2g-v2.2 fixed)

Details

(Whiteboard: [systemsfe])

Attachments

(5 attachments, 1 obsolete attachment)

(Reporter)

Description

4 years ago
Created attachment 8482716 [details]
Blurry and missaligned SSL Lock

Hey Kevin,

Feel free to redirect this bug, I wasn't sure who to assign it to.

The ssl icon looks blurry in the chrome, while other icons look sharp.  Can you take a look and let me know if it's a visual asset problem? 

Also, the icon should take up 30 px of horizontal space, so the space is equal on both sides of the icon.

Here's the spec for reference:
https://mozilla.box.com/s/oedme1y7u6m3s6lxvk0a

Thanks!
(Reporter)

Updated

4 years ago
Component: Gaia::Browser → Gaia::System::Browser Chrome
(Reporter)

Comment 1

4 years ago
(In reply to Eric Pang [:epang] from comment #0)
> Created attachment 8482716 [details]
> Blurry and missaligned SSL Lock
> 
> Hey Kevin,
> 
> Feel free to redirect this bug, I wasn't sure who to assign it to.
> 
> The ssl icon looks blurry in the chrome, while other icons look sharp.  Can
> you take a look and let me know if it's a visual asset problem? 
> 
> Also, the icon should take up 30 px of horizontal space, so the space is
> equal on both sides of the icon.
> 
> Here's the spec for reference:
> https://mozilla.box.com/s/oedme1y7u6m3s6lxvk0a
> 
> Thanks!

Sorry, looks like the visual assets are too small, fixing them now :).
(Reporter)

Comment 2

4 years ago
(In reply to Eric Pang [:epang] from comment #1)
> (In reply to Eric Pang [:epang] from comment #0)
> > Created attachment 8482716 [details]
> > Blurry and missaligned SSL Lock
> > 
> > Hey Kevin,
> > 
> > Feel free to redirect this bug, I wasn't sure who to assign it to.
> > 
> > The ssl icon looks blurry in the chrome, while other icons look sharp.  Can
> > you take a look and let me know if it's a visual asset problem? 
> > 
> > Also, the icon should take up 30 px of horizontal space, so the space is
> > equal on both sides of the icon.
> > 
> > Here's the spec for reference:
> > https://mozilla.box.com/s/oedme1y7u6m3s6lxvk0a
> > 
> > Thanks!
> 
> Sorry, looks like the visual assets are too small, fixing them now :).

the ssl lock and broken ssl can both be found with the browser chrome icons
https://mozilla.box.com/s/xleyd4fnpl5e2gvo2bxr

They are resized to the spec now, hopefully this fixes the blurriness and margins, thanks!
(Assignee)

Comment 3

4 years ago
Created attachment 8482832 [details] [review]
Pull request - Update SSL Icon assets
(Assignee)

Comment 4

4 years ago
Created attachment 8482833 [details]
Screenshot - Implementation on flame

Hey Eric - Could you take a look at this screenshot on a flame? I've centered the icon within a 3rem box, just wanted to make sure this is what you were looking for. Thanks!
Attachment #8482833 - Flags: ui-review?(epang)
(Reporter)

Comment 5

4 years ago
(In reply to Kevin Grandon :kgrandon from comment #4)
> Created attachment 8482833 [details]
> Screenshot - Implementation on flame
> 
> Hey Eric - Could you take a look at this screenshot on a flame? I've
> centered the icon within a 3rem box, just wanted to make sure this is what
> you were looking for. Thanks!

Hey Kevin, looks like i made the icons too small.  I've updated them on box again.  

https://mozilla.box.com/s/xleyd4fnpl5e2gvo2bxr

Sorry for all the back and forth.  I think it should be good after this, I'll look to ui-review tomorrow morning. Thanks again for working on this!
Flags: needinfo?(kgrandon)
(Assignee)

Comment 6

4 years ago
Created attachment 8483719 [details]
Assets - SSL Icons in a zip

Uploading a zip of the icons here in case they are needed for the future.
Flags: needinfo?(kgrandon)
(Assignee)

Updated

4 years ago
Attachment #8482833 - Attachment is obsolete: true
Attachment #8482833 - Flags: ui-review?(epang)
(Assignee)

Comment 7

4 years ago
Comment on attachment 8482832 [details] [review]
Pull request - Update SSL Icon assets

Hey Eric - assets have been updated now.

Since this is mainly just an asset swap, would you mind flipping the review? flag here instead of ui-review if it looks good to you? I'll try to provide a screenshot as well here shortly.
Attachment #8482832 - Flags: review?(epang)
(Assignee)

Comment 8

4 years ago
Created attachment 8483773 [details]
Screenshot of implementation
(Reporter)

Comment 9

4 years ago
(In reply to Kevin Grandon :kgrandon from comment #8)
> Created attachment 8483773 [details]
> Screenshot of implementation

The icon looks good now, just one more nit pick.. is it possible to horizontally center the icon between the edge of the input field and where the text starts?  If possible IRC me when it's done so I can quickly R+ :)  Thanks again Kevin!
Flags: needinfo?(kgrandon)
(Assignee)

Comment 10

4 years ago
Created attachment 8484245 [details]
Updated implementation screenshot
Flags: needinfo?(kgrandon)
(Reporter)

Comment 11

4 years ago
Comment on attachment 8482832 [details] [review]
Pull request - Update SSL Icon assets

Just needs to move 1px right, but you already know what :). R+
Thanks again!
Attachment #8482832 - Flags: review?(epang) → review+
(Assignee)

Comment 12

4 years ago
In master: https://github.com/mozilla-b2g/gaia/commit/1d910d919e778622ef0569f3f6896fae1a609d56
Blocks: 1055065
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Assignee)

Updated

4 years ago
status-b2g-v2.0: --- → unaffected
status-b2g-v2.1: --- → affected
status-b2g-v2.2: --- → fixed
(Assignee)

Updated

4 years ago
Target Milestone: --- → 2.1 S4 (12sep)
(Assignee)

Comment 13

4 years ago
Comment on attachment 8482832 [details] [review]
Pull request - Update SSL Icon assets

This is very low-risk visual polish we would like to uplift.
Attachment #8482832 - Flags: approval-gaia-v2.1?(bbajaj)
Attachment #8482832 - Flags: approval-gaia-v2.1?(bbajaj) → approval-gaia-v2.1+
You need to log in before you can comment on or make changes to this bug.