Closed
Bug 1061681
Opened 10 years ago
Closed 10 years ago
Rename fromchange/tochange params, since they behave differently than on pushlog / TBPL
Categories
(Tree Management :: Treeherder, defect, P3)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: emorley, Unassigned)
Details
(Keywords: regression)
This may possibly be wontfix, but in treeherder, fromchange=REV_SHA is inclusive, whereas for TBPL and the hgweb pushlog, it is exclusive.
ie for this pushlog:
PUSH_5
PUSH_4
PUSH_3
PUSH_2
PUSH_1
&fromchange=PUSH_2_SHA&tochange=PUSH_4_SHA
Would return pushes 3 & 4 in TBPL, but 2, 3 & 4 in Treeherder.
Reporter | ||
Updated•10 years ago
|
Blocks: treeherder-dev-transition
Reporter | ||
Updated•10 years ago
|
Priority: -- → P3
Reporter | ||
Comment 1•10 years ago
|
||
I'm thinking that perhaps we just wontfix this and maybe rename the params so that they don't imply the same behaviour pushlog/tbpl? (eg fromrev, torev)
Reporter | ||
Updated•10 years ago
|
Summary: The param 'fromchange' is inclusive rather than exclusive → Rename fromchange/tochange params, since they behave differently than on pushlog / TBPL
Reporter | ||
Updated•10 years ago
|
Assignee: nobody → emorley
Status: NEW → ASSIGNED
Reporter | ||
Updated•10 years ago
|
No longer blocks: treeherder-dev-transition
Keywords: regression
Reporter | ||
Comment 2•10 years ago
|
||
I don't think this is worth the churn right now, given it needs both service and UI changes, which even if timed perfectly should probably still have a period of time where we also support the old name on the service etc etc. Also I tend to prefer Treeherder's interpretation of "fromchange" - if anything, it's pushlog that should change to "sincechange" or something similar.
Assignee: emorley → nobody
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•