Closed Bug 1061699 Opened 6 years ago Closed 6 years ago

crash in _moz_cairo_win32_surface_create_with_d3dsurface9

Categories

(Core :: Graphics, defect, critical)

Other Branch
x86
Windows NT
defect
Not set
critical

Tracking

()

VERIFIED FIXED
mozilla35
Tracking Status
firefox33 + verified
firefox34 + verified
firefox35 --- verified

People

(Reporter: bjacob, Assigned: nical)

References

(Blocks 1 open bug)

Details

(Keywords: crash)

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is 
report bp-595d7093-869c-4db0-b266-283952140901.
=============================================================

Although this is a crash with D3D9 layers, I found it by looking at the list of topcrashers for sessions attempting D3D11 layers, which really is just Windows users of pre-release Firefox channels. In doubt, I'll still block bug 1061693.
Again, a bug happening in rare cases when failing to allocate surfaces in places where the code expects to always succeed. Here we have the ContentClient/RotatedBuffer mess so things blow up a bit later when attempting to borrow a DrawTarget from a surface that we failed to allocate. The easiest fix here is to not crash release builds. Ideally ContentClient would better handle locking failure, but the result (in term of "oh snap, can't render this layer" would be the same anyway).
Assignee: nobody → nical.bugzilla
Attachment #8489338 - Flags: review?(bas)
Attachment #8489338 - Flags: review?(bas) → review+
https://hg.mozilla.org/mozilla-central/rev/a83b8731e752
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Tracking for 33 since this is a crash signature that popped out when OMTC was turned off. Nical is this safe to uplift?
Flags: needinfo?(nical.bugzilla)
Comment on attachment 8489338 [details] [diff] [review]
Don't crash release builds when attempting to borrow a DrawTarget from an unlocked TextureClient

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]: Some crashes on windows in places where we should have been able to recover.
[Describe test coverage new/current, TBPL]:
[Risks and why]: low risk, very simple patch, trivial to backout
[String/UUID change made/needed]:
Attachment #8489338 - Flags: approval-mozilla-beta?
Attachment #8489338 - Flags: approval-mozilla-aurora?
Flags: needinfo?(nical.bugzilla)
Attachment #8489338 - Flags: approval-mozilla-beta?
Attachment #8489338 - Flags: approval-mozilla-beta+
Attachment #8489338 - Flags: approval-mozilla-aurora?
Attachment #8489338 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.