1061701 - Overflow-prone binary search algorithms in NSS

Status: RESOLVED FIXED

(NSS :: Tools, defect)

Comment 1

[Georg Fritzsche [:gfritzsche]]

See bug 917918, comment 0 for the issue. This is about the security/nss parts.

Comment 2

[Georg Fritzsche [:gfritzsche]]

Attachment: Fixes

Comment 3

[Georg Fritzsche [:gfritzsche]]

Attachment: Fixes

Comment 4

[Kai Engert (:KaiE:)]

Comment on attachment 8482756 [details] [diff] [review]
Fixes

r=kaie

Thanks, looks good to me. So this avoids potential integer overflows. Luckily the affected code is only in a test utility, in a build/dependency utility, and in a signing utlity. The signing utility might be the most critical one, but the code only does a lookup in a very small tables of error codes, so it shouldn't ever get close to an overflow.

Comment 5

[Kai Engert (:KaiE:)]

Do you require any special timing for checking in the patch, as you've marked it security sensitive? Any suggestions for the public commit message?

Comment 6

[Georg Fritzsche [:gfritzsche]]

[Tracking Requested - why for this release]:

Per bug 917918 this will probably held back until the patches there reach middle or late beta. Requesting tracking here as well so this doesn't get lost.

Comment 7

[Georg Fritzsche [:gfritzsche]]

(In reply to Georg Fritzsche [:gfritzsche] from comment #6)
> [Tracking Requested - why for this release]:
> 
> Per bug 917918 this will probably held back until the patches there reach
> middle or late beta. Requesting tracking here as well so this doesn't get
> lost.

Checking back with dveditz though.

Comment 8

[Kai Engert (:KaiE:)]

Note that NSS is on a separate release schedule. We must land into NSS earlier, so it can be included in a release version, which can then be uplifted into mozilla branches.

Given this isn't a serious issue inside of NSS, I suggest that we land into NSS as soon as you're ready to accept this bug becomes publicly known.

Comment 9

[Daniel Veditz [:dveditz]]

If this isn't part of the main NSS library used by network-exposed clients and servers then we can wait to land this after the Firefox-specific ones in bug 917918. The uplift timing for the NSS part doesn't really matter then.

Comment 10

[Lawrence Mandel [:lmandel] (use needinfo)]

It's now middle Beta. What's the plan for getting this fixed? Do you still want to take a fix in 34?

Comment 11

[Georg Fritzsche [:gfritzsche]]

[Tracking Requested - why for this release]:
Bug 917918 is on the trains for 35, so per comment 9 we should land after that is released.

Comment 12

[Daniel Veditz [:dveditz]]

We don't need these fixed in Firefox: these changes are in utils that are not part of the shipping browser.

Comment 13

[Georg Fritzsche [:gfritzsche]]

Would this be good to land now?

Comment 14

[Daniel Veditz [:dveditz]]

Sure, any time.

Comment 15

[Georg Fritzsche [:gfritzsche]]

This still applies fine - Martin, i heard you might be able to land this?

Comment 16

[Martin Thomson [:mt:]]

https://hg.mozilla.org/projects/nss/rev/bb14a192a3c3