crash in mozilla::gfx::DrawTargetDual::DrawTargetDual(mozilla::gfx::DrawTarget*, mozilla::gfx::DrawTarget*)

VERIFIED FIXED in Firefox 33

Status

()

defect
--
critical
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: bjacob, Assigned: nical)

Tracking

(Blocks 1 bug, {crash})

Other Branch
mozilla35
x86
Windows NT
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox33+ verified, firefox34+ verified, firefox35 verified)

Details

(crash signature)

Attachments

(1 attachment)

This bug was filed from the Socorro interface and is 
report bp-90110b5b-a94c-4276-8044-ae9bd2140901.
=============================================================

This is the 26th topcrasher among D3D11-attempting sessions (prerelease channels on Windows).
Instead, return null. This way we will most likely still crash but in the NS_ABORT_OOM here; http://dxr.mozilla.org/mozilla-central/source/gfx/thebes/gfxContext.cpp?from=gfxContext.cpp&case=true#1598

Which is more meaningful for crash stats and reduce the number of bugs open for the same problem.
Assignee: nobody → nical.bugzilla
Attachment #8489344 - Flags: review?(bas)
Comment on attachment 8489344 [details] [diff] [review]
Don't crash in DrawTargetDual if allocation fails.

Review of attachment 8489344 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/2d/DrawTargetDual.cpp
@@ +185,5 @@
>  {
>    RefPtr<DrawTarget> dtA = mA->CreateSimilarDrawTarget(aSize, aFormat);
>    RefPtr<DrawTarget> dtB = mB->CreateSimilarDrawTarget(aSize, aFormat);
>  
> +  if (!dtA || !dtB) {

nit: gfxWarning() <<
Attachment #8489344 - Flags: review?(bas) → review+
https://hg.mozilla.org/mozilla-central/rev/52a09180f59d
https://hg.mozilla.org/mozilla-central/rev/ed7fb4c12ba9
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Tracking for 33 since this showed up as OMTC-related. Nical is this safe to uplift?
Flags: needinfo?(nical.bugzilla)
Comment on attachment 8489344 [details] [diff] [review]
Don't crash in DrawTargetDual if allocation fails.

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]: Some crashes on windows where we should have been able to recover without crashing (although failing to allocate a surface probably means we are low on memory, or something less fatal yet abnormal is going on).
[Describe test coverage new/current, TBPL]:
[Risks and why]: low, trivial patch.
[String/UUID change made/needed]:
Attachment #8489344 - Flags: approval-mozilla-beta?
Attachment #8489344 - Flags: approval-mozilla-aurora?
Flags: needinfo?(nical.bugzilla)
Attachment #8489344 - Flags: approval-mozilla-beta?
Attachment #8489344 - Flags: approval-mozilla-beta+
Attachment #8489344 - Flags: approval-mozilla-aurora?
Attachment #8489344 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.