1061712 - crash in mozilla::gfx::DrawTargetDual::DrawTargetDual(mozilla::gfx::DrawTarget*, mozilla::gfx::DrawTarget*)

Status: VERIFIED FIXED

(Core :: Graphics, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

This bug was filed from the Socorro interface and is 
report bp-90110b5b-a94c-4276-8044-ae9bd2140901.
=============================================================

This is the 26th topcrasher among D3D11-attempting sessions (prerelease channels on Windows).

Comment 1

[Nicolas Silva [:nical]]

Attachment: Don't crash in DrawTargetDual if allocation fails.

Instead, return null. This way we will most likely still crash but in the NS_ABORT_OOM here; http://dxr.mozilla.org/mozilla-central/source/gfx/thebes/gfxContext.cpp?from=gfxContext.cpp&case=true#1598

Which is more meaningful for crash stats and reduce the number of bugs open for the same problem.

Comment 2

[Bas Schouten (:bas.schouten)]

Comment on attachment 8489344 [details] [diff] [review]
Don't crash in DrawTargetDual if allocation fails.

Review of attachment 8489344 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/2d/DrawTargetDual.cpp
@@ +185,5 @@
>  {
>    RefPtr<DrawTarget> dtA = mA->CreateSimilarDrawTarget(aSize, aFormat);
>    RefPtr<DrawTarget> dtB = mB->CreateSimilarDrawTarget(aSize, aFormat);
>  
> +  if (!dtA || !dtB) {

nit: gfxWarning() <<

Comment 3

[Nicolas Silva [:nical]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/52a09180f59d

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/52a09180f59d
https://hg.mozilla.org/mozilla-central/rev/ed7fb4c12ba9

Comment 5

[Benjamin Smedberg]

Tracking for 33 since this showed up as OMTC-related. Nical is this safe to uplift?

Comment 6

[Nicolas Silva [:nical]]

Comment on attachment 8489344 [details] [diff] [review]
Don't crash in DrawTargetDual if allocation fails.

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]: Some crashes on windows where we should have been able to recover without crashing (although failing to allocate a surface probably means we are low on memory, or something less fatal yet abnormal is going on).
[Describe test coverage new/current, TBPL]:
[Risks and why]: low, trivial patch.
[String/UUID change made/needed]:

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2010e9a2e39e
https://hg.mozilla.org/releases/mozilla-beta/rev/69047a750833

Comment 8

[Florin Mezei, QA (:FlorinMezei)]

Socorro [1] shows no more crashes in builds after this landed, over the past 4 weeks.

[1] - https://crash-stats.mozilla.com/report/list?product=Firefox&range_unit=days&range_value=28&signature=mozilla%3A%3Agfx%3A%3ADrawTargetDual%3A%3ADrawTargetDual%28mozilla%3A%3Agfx%3A%3ADrawTarget%2A%2C+mozilla%3A%3Agfx%3A%3ADrawTarget%2A%29