The default bug view has changed. See this FAQ.

Restore Defaults does not reset the current theme

VERIFIED FIXED in Firefox 49

Status

()

Firefox
Toolbars and Customization
VERIFIED FIXED
3 years ago
6 months ago

People

(Reporter: jaws, Assigned: ktbee, Mentored)

Tracking

(Depends on: 1 bug)

34 Branch
Firefox 49
Points:
3
Dependency tree / graph
Bug Flags:
firefox-backlog +

Firefox Tracking Flags

(firefox34 affected, firefox35 affected, firefox49 verified, firefox50 verified)

Details

(Whiteboard: [outreachy-12])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

STR:
Open customization mode
Choose a lightweight theme from the recommended themes list
Click on "Restore Defaults"

Expected:
The theme is switched back to Default

Actual:
The theme is unchanged
Flags: firefox-backlog+
Note also that when this bug is fixed, "Undo Restore Default" will also need to be supported that restores the previously selected theme.

Updated

3 years ago
Flags: qe-verify?
Flags: qe-verify? → qe-verify+
status-firefox34: --- → affected
status-firefox35: --- → affected
Version: unspecified → 34 Branch
(Reporter)

Updated

11 months ago
Mentor: jaws@mozilla.com
Whiteboard: [outreachy-12]
(Reporter)

Updated

11 months ago
Points: --- → 3
Katie, would you like to take this bug next?
Flags: needinfo?(kbroida)
(Assignee)

Comment 3

11 months ago
Sure thing!
Flags: needinfo?(kbroida)
(Reporter)

Updated

11 months ago
Assignee: nobody → kbroida
Status: NEW → ASSIGNED
(Assignee)

Comment 4

11 months ago
Created attachment 8750452 [details]
MozReview Request: Bug 1061747 - Makes the "Restore Defaults" button reset the browser theme. Also adds test to check whether this button resets to the default theme successfully.r?jaws

Review commit: https://reviewboard.mozilla.org/r/51423/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/51423/
Attachment #8750452 - Flags: review?(jaws)
(Assignee)

Comment 5

11 months ago
I've submitted a patch for making sure the "Restore Defaults" button resets the browser theme to the default. However, I noticed another place a fix might be needed. If you enter customize mode and only change the theme, you're not able to click "Restore Defaults." This button is only available once you change another unrelated setting. Should I add to this patch to make sure that changing the theme will allow you to use the "Restore Defaults" button? Or should that be a separate bug report?
Comment on attachment 8750452 [details]
MozReview Request: Bug 1061747 - Makes the "Restore Defaults" button reset the browser theme. Also adds test to check whether this button resets to the default theme successfully.r?jaws

https://reviewboard.mozilla.org/r/51423/#review48259

Looks good, and thanks for updating the test. We should also restore the previous theme if the user hits "Undo" after the Restore Defaults. See browser_970511_undo_restore_defaults.js for the test that will need updating too.
Attachment #8750452 - Flags: review?(jaws)
(In reply to Katie Broida from comment #5)
> Should I add to this patch to
> make sure that changing the theme will allow you to use the "Restore
> Defaults" button? Or should that be a separate bug report?

That should be part of this patch.
In CustomizableUI.jsm, you can follow how state is added to gUIStateBeforeReset so "Undo" can re-set it.
(Assignee)

Comment 9

11 months ago
Comment on attachment 8750452 [details]
MozReview Request: Bug 1061747 - Makes the "Restore Defaults" button reset the browser theme. Also adds test to check whether this button resets to the default theme successfully.r?jaws

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/51423/diff/1-2/
Attachment #8750452 - Flags: review?(jaws)
Comment on attachment 8750452 [details]
MozReview Request: Bug 1061747 - Makes the "Restore Defaults" button reset the browser theme. Also adds test to check whether this button resets to the default theme successfully.r?jaws

https://reviewboard.mozilla.org/r/51423/#review51086

Looks great! Sorry I didn't get to this sooner.
Attachment #8750452 - Flags: review?(jaws) → review+
(Reporter)

Updated

10 months ago
Keywords: checkin-needed

Comment 11

10 months ago
seems there are problems to apply:

applying 6962e21b4433
patching file browser/components/customizableui/CustomizableUI.jsm
Hunk #2 FAILED at 147
1 out of 6 hunks FAILED -- saving rejects to file browser/components/customizableui/CustomizableUI.jsm.rej
patching file browser/components/customizableui/CustomizeMode.jsm
Hunk #3 FAILED at 1456
1 out of 3 hunks FAILED -- saving rejects to file browser/components/customizableui/CustomizeMode.jsm.rej
patching file browser/components/customizableui/test/browser_1007336_lwthemes_in_customize_mode.js
Hunk #1 FAILED at 46
1 out of 1 hunks FAILED -- saving rejects to file browser/components/customizableui/test/browser_1007336_lwthemes_in_customize_mode.js.rej
patch failed to apply
abort: fix up the working directory and run hg transplant --continue
Flags: needinfo?(kbroida)
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/a11b2a2868026b88fe75827f19719ade76eca1bd
Bug 1061747 - Restore Defaults should reset the current theme. r=jaws
(Reporter)

Updated

10 months ago
Flags: needinfo?(kbroida)

Comment 13

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a11b2a286802
Status: ASSIGNED → RESOLVED
Last Resolved: 10 months ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
I managed to reproduce this issue on Firefox 48.0b1 and on Windows 10 x64.
The issue is no longer reproducible on Firefox 49.0a2 (2016-06-16) or on Firefox 50.0a1 (2016-06-15).
The tests were performed on Windows 10 x64, Mac OS X 10.11.1 and on Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
status-firefox49: fixed → verified
status-firefox50: --- → verified
Flags: qe-verify+

Updated

6 months ago
Depends on: 1306584

Updated

6 months ago
Depends on: 1306561
You need to log in before you can comment on or make changes to this bug.