1061756 - Remove MozLoopService #ifdef DEBUG and fix tests

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect)

Description

[Matthew N. [:MattN]]

Since I found out now that we can do the following in tests, the #ifdef DEBUG stuff that I added should be removed.

const MozLoopServiceInternal = Cu.import("resource:///modules/loop/MozLoopService.jsm", {}).
                               MozLoopServiceInternal;


bholley, is it expected that I can access non-exported symbols using this method? I don't want to rely on it if that's not expected.

Comment 1

[Bobby Holley (:bholley)]

Per the IDL it is expected. Possibly not the best design decision, but unlikely to change at this point. Rely away.

Comment 2

[u279076]

Untracking for QE. Please needinfo me to request testing.

Comment 3

[Matthew N. [:MattN]]

Attachment: v.1 Switch to Cu.import of the non-exported symbols

Comment 4

[Matthew N. [:MattN]]

https://hg.mozilla.org/integration/fx-team/rev/aecfd2bc7afe

Thanks bholley and jaws!

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/aecfd2bc7afe

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8482990 [details] [diff] [review]
v.1 Switch to Cu.import of the non-exported symbols

Approval Request Comment
Uplift request for patches staged and tested on Fig

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/282f7c4d08e1

Comment 8

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8482990 [details] [diff] [review]
v.1 Switch to Cu.import of the non-exported symbols

I worked with Randell and Maire on uplifting a large number of Loop bugs at once. All of the bugs have been staged on Fig and tested by QE before uplift to Aurora. As well, all of the bugs are isolated to the Loop client. Randell handled the uplift with my approval. I am adding approval to the bug after the fact for bookkeeping.