Remove MozLoopService #ifdef DEBUG and fix tests

RESOLVED FIXED in Firefox 34

Status

Product:
Hello (Loop)
Component:
Client
Status:
RESOLVED FIXED
Reported:
4 years ago
Modified:
4 years ago

People

(Reporter: MattN, Assigned: MattN)

Tracking

Version:
unspecified
Target:
mozilla35
Points:
1
Bug Flags:
firefox-backlog +
qe-verify -

Firefox Tracking Flags

(firefox34 fixed, firefox35 fixed)

Details

(Whiteboard: [loop-uplift])

Attachments

(1 attachment)

v.1 Switch to Cu.import of the non-exported symbols
12.19 KB, patch
jaws
: review+
lmandel
: approval-mozilla-aurora+
Details | Diff | Splinter Review
(Assignee)

Description

•
4 years ago 
Since I found out now that we can do the following in tests, the #ifdef DEBUG stuff that I added should be removed.

const MozLoopServiceInternal = Cu.import("resource:///modules/loop/MozLoopService.jsm", {}).
                               MozLoopServiceInternal;


bholley, is it expected that I can access non-exported symbols using this method? I don't want to rely on it if that's not expected.
Flags: needinfo?(bobbyholley)
Flags: firefox-backlog+

Comment 1

•
4 years ago 
Per the IDL it is expected. Possibly not the best design decision, but unlikely to change at this point. Rely away.
Flags: needinfo?(bobbyholley)

Comment 2

•
4 years ago 
Untracking for QE. Please needinfo me to request testing.
Flags: qe-verify-
 (Assignee)

Comment 3

•
4 years ago 
Created attachment 8482990 [details] [diff] [review]
v.1 Switch to Cu.import of the non-exported symbols
Attachment #8482990 - Flags: review?(jaws)
Keywords: checkin-needed
 (Assignee)

Comment 4

•
4 years ago 
https://hg.mozilla.org/integration/fx-team/rev/aecfd2bc7afe

Thanks bholley and jaws!
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]

Comment 5

•
4 years ago 
https://hg.mozilla.org/mozilla-central/rev/aecfd2bc7afe
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla35

Updated

•
4 years ago
Whiteboard: [loop-uplift]

Comment 6

•
4 years ago 
Comment on attachment 8482990 [details] [diff] [review]
v.1 Switch to Cu.import of the non-exported symbols

Approval Request Comment
Uplift request for patches staged and tested on Fig
Attachment #8482990 - Flags: approval-mozilla-aurora?
status-firefox34: --- → fixed
status-firefox35: --- → fixed

Comment 8

•
4 years ago 
Comment on attachment 8482990 [details] [diff] [review]
v.1 Switch to Cu.import of the non-exported symbols

I worked with Randell and Maire on uplifting a large number of Loop bugs at once. All of the bugs have been staged on Fig and tested by QE before uplift to Aurora. As well, all of the bugs are isolated to the Loop client. Randell handled the uplift with my approval. I am adding approval to the bug after the fact for bookkeeping.
Attachment #8482990 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.