1061759 - Profiler 'calls' columns is improperly named

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect, P3)

Description

[Benoit Girard (:BenWa)]

The profiler has a column labeled 'Calls'. If we're still using sampling data to collect the data then we have no way of knowing 'Calls', what we're showing is instead 'Samples'.

At the same time it might be a good time to provide tooltips on mouse over explaining exactly how the columns are defined. For instance we should mention that 'Time' is a statistical estimation.

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 2

[Benoit Girard (:BenWa)]

Are we going to consider uplifting this? AFAIK the new UI hasn't shipped and it would be nice if this was fixed in the first version that ships.

Comment 3

[Patrick Brosset <:pbro>]

Comment on attachment 8491673 [details] [diff] [review]
v1

Review of attachment 8491673 [details] [diff] [review]:
-----------------------------------------------------------------

Code changes look like a simple search/replace from "invocations" to "samples", so fine for R+. Are we not going to use this bug to add tooltips though, as suggested by BenWa. I too think that would help a lot.

Comment 4

[Victor Porof [:vporof][:vp]]

Filed bug 1069910.

Comment 5

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/c5247437d857

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c5247437d857