1061760 - mstange's dumping ground for experimental patches that get rid of plugin widgets on OS X

Status: RESOLVED DUPLICATE of bug 1092630

(Core :: Widget: Cocoa, defect)

Comment 1

[Markus Stange [:mstange]]

Attachment: Don't allow plugin ChildViews into the NSView hierarchy

Comment 2

[Markus Stange [:mstange]]

Attachment: Translate Gecko focus events to plugin focus events

because there's no longer an NSView that can send plugin focus events when becoming firstResponder

Comment 3

[Markus Stange [:mstange]]

Attachment: Send plugin key events along with regular Gecko key events

Regular Gecko key events get targeted to the focused frame appropriately. (It looked to me like that's not the case for plugin key events, but I haven't verified that.)

Comment 4

[Markus Stange [:mstange]]

Attachment: Always attach plugin mouse events to Gecko mouse events

Comment 5

[Markus Stange [:mstange]]

Attachment: Never create widgets for plugins

Comment 6

[Markus Stange [:mstange]]

Attachment: Set up a listener for the CoreAnimation timer even without a plugin widget

Comment 7

[Markus Stange [:mstange]]

Attachment: Send events to the plugin even when there's no widget

Comment 8

[Markus Stange [:mstange]]

Attachment: Make GetPluginPortFromWidget return something when there's no widget

Comment 9

[Markus Stange [:mstange]]

Attachment: Hack other stuff to not break when there's no widget

Comment 10

[Markus Stange [:mstange]]

Attachment: Make FixUpPluginWindow work when there's no widget

This always treats all plugins as completely visible and puts their top left corner at 0,0.

Comment 11

[Markus Stange [:mstange]]

Attachment: Fix up mouse event coordinates

Since the plugin now thinks it's at 0,0, event coordinates need to be made relative to the plugin.

Comment 12

[Markus Stange [:mstange]]

Attachment: Recreate plugin mouse events from Gecko mouse events

Comment 13

[Markus Stange [:mstange]]

Attachment: Rip out most plugin support from cocoa widgets

One of the few things remaining is that key events still come with an attached plugin event.

Comment 14

[Benoit Jacob [:bjacob] (mostly away)]

mstange++++++++++++++++++++++

Comment 15

[Markus Stange [:mstange]]

Bug 1092630 has landed, so I'll close this bug. Yay!