Closed Bug 1061768 Opened 5 years ago Closed 5 years ago

BuildID in em:updateURL and UI is empty, seems that @GRE_BUILDID@ is not set during build

Categories

(Calendar :: Build Config, defect)

Product:
Calendar
Component:
Build Config
Version:
Lightning 3.6
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: ssitter, Assigned: ssitter)

Details

Attachments

(1 file)

read BuildID from application.ini
1.08 KB, patch
Fallen
: review+
Details | Diff | Splinter Review 
Current Lightning Trunk builds don't show a Build ID, e.g. the latest one from 
> https://ftp.mozilla.org/pub/mozilla.org/calendar/lightning/tinderbox-builds/comm-central-win32/latest/

When checking install.rdf it just contains lines like:
>     <em:version>3.6a1</em:version> <!-- BuildID= -->
>     <em:developer>Build ID: </em:developer>

It seems that @GRE_BUILDID@ is not set.
The em:updateURL for nightly updates is broken too due to empty buildID.
Summary: Displayed Build ID is empty, seems that @GRE_BUILDID@ is not set during build → BuildID in em:updateURL and UI is empty, seems that @GRE_BUILDID@ is not set during build
On my local build the file $(LIBXUL_DIST)/bin/platform.ini doesn't exist yet when calendar/lightning/Makefile.in is processed. But there is file $(LIBXUL_DIST)/bin/application.ini that contains the BuildID too. The patch changes Makefile.in to read the BuildID from application.ini.
Assignee: nobody → ssitter
Status: NEW → ASSIGNED
Attachment #8496985 - Flags: review?(philipp)
Comment on attachment 8496985 [details] [diff] [review]
read BuildID from application.ini

Review of attachment 8496985 [details] [diff] [review]:
-----------------------------------------------------------------

r=philipp and approval where ever you need it.
Attachment #8496985 - Flags: review?(philipp) → review+
It seems ok in the 3.5 beta build therefore I think we need this in 3.7 and 3.6 only. Unfortunately my hg account has been disabled, setting checkin-needed for comm-central and comm-aurora.
Keywords: checkin-needed
Pushed to https://hg.mozilla.org/comm-central/rev/fedb0ee60207
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 3.7
Pushed to https://hg.mozilla.org/releases/comm-aurora/rev/3af6b75f9528
Target Milestone: 3.7 → 3.6
You need to log in before you can comment on or make changes to this bug.