Closed Bug 1061798 Opened 8 years ago Closed 8 years ago

page number should reset if you change filters

Categories

(Input Graveyard :: Dashboard, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: willkg, Assigned: aokoye, Mentored)

Details

(Whiteboard: u=user c=dashboard p= s=input.2014q4)

Cheng said this:

    <Cww> willkg: new input bug, btw, if you are on page>1 and you
    change a filter (say, version), you stay on page n>1 on the results
    page which results in "No feedback matches that criteria."

STR:

1. go to https://input.mozilla.org/
2. choose "Firefox" product
3. go to page 5 (or something that exceeds the count of the version you choose next)
4. choose "33.0a2" version

Results:

You end up on a "No feedback matches that criteria" page.

Expected:

Changing filters should start you back at page 0.
Tossing this in this quarter. I'm pretty sure this is an easy fix. When you select/unselect a filter, I think there's some JS that kicks off to figure out the new querystring. Pretty sure we need to change that to ignore the page variable and then we'd be all set.
Whiteboard: u=user c=dashboard p= s=input.2014q3
Whiteboard: u=user c=dashboard p= s=input.2014q3 → u=user c=dashboard p= s=input.2014q4
Assigning this to Adam!
Assignee: nobody → aokoye
Status: NEW → ASSIGNED
Sent a PR - https://github.com/mozilla/fjord/pull/364

r?
Landed in master in https://github.com/mozilla/fjord/commit/55fede081b7e9aad56c691052724322ed92e2b62

I'll push this to production on monday and mark it fixed then.

Thank you!
Pushed to prod just now.

Thank you!
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Retro-actively marking myself as a mentor.
Mentor: willkg
Product: Input → Input Graveyard
You need to log in before you can comment on or make changes to this bug.