profile.sh should support using symbol.api

RESOLVED FIXED in Firefox OS v2.2

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: BenWa, Assigned: wcosta)

Tracking

unspecified
2.1 S5 (26sep)
x86
Mac OS X
Dependency tree / graph

Firefox Tracking Flags

(b2g-v2.2 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Once bug 1061800 is ready we should be able to prepare our symbols and look them up by sending a request to symbolapi.mozilla.org. We should modify profile.sh to support sending the request instead of looking for local symbol files like it does for developer builds.
(Assignee)

Updated

4 years ago
Depends on: 1062447
(Assignee)

Updated

4 years ago
See Also: → bug 1062459
(Assignee)

Updated

4 years ago
Assignee: nobody → wcosta
(Assignee)

Updated

4 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

4 years ago
Depends on: 1022928
(Assignee)

Comment 1

4 years ago
(In reply to Benoit Girard (:BenWa) from comment #0)
> Once bug 1061800 is ready we should be able to prepare our symbols and look
> them up by sending a request to symbolapi.mozilla.org. We should modify
> profile.sh to support sending the request instead of looking for local
> symbol files like it does for developer builds.

I have a a functional patch [1] for that that works on a local server. For tests, I am using "Firefox" as a symbol source. Do you know what is the symbol source for B2G?

[1] http://bit.ly/1qZ9jyX
Flags: needinfo?(bgirard)
(Reporter)

Comment 2

4 years ago
You're going to want to do something similar to this but on b2g:
https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Profiling_with_the_Built-in_Profiler_and_Local_Symbols_on_Windows

Generate the breakpad sym files, run a local symbol server and use your patch to talk to that symbol server. That should start resolving the symbols if the library id match.
Flags: needinfo?(bgirard)
(Assignee)

Comment 3

4 years ago
(In reply to Benoit Girard (:BenWa) from comment #2)
> You're going to want to do something similar to this but on b2g:
> https://developer.mozilla.org/en-US/docs/Mozilla/Performance/
> Profiling_with_the_Built-in_Profiler_and_Local_Symbols_on_Windows
> 
> Generate the breakpad sym files, run a local symbol server and use your
> patch to talk to that symbol server. That should start resolving the symbols
> if the library id match.

Yep, I did that, my questionis what symbol source to use for b2g. For tests I am using Firefox, but I guess there is another for b2g.
(Reporter)

Comment 4

4 years ago
Opps.

I think you'll need the extend the snappy symbol server to accept an optional b2g source directory. When you run this step on b2g: https://developer.mozilla.org/en-US/docs/Building_Firefox_with_Debug_Symbols#Breakpad_symbol_files You should get a folder with the symbols for the b2g build. Then you can point the b2g source to the directory that contains the breakpad symbol files.
(Assignee)

Comment 5

4 years ago
Created attachment 8492390 [details] [review]
Support symbol server API
Attachment #8492390 - Flags: review?(dhylands)
Comment on attachment 8492390 [details] [review]
Support symbol server API

Just one comment on he PR. r=me with that addressed.
Attachment #8492390 - Flags: review?(dhylands) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
Master: https://github.com/mozilla-b2g/B2G/commit/f1aeaa147062ef9ab6528cd5061d479b0eee22b4
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-b2g-v2.2: --- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S5 (26sep)
(Assignee)

Updated

4 years ago
Blocks: 1072590
You need to log in before you can comment on or make changes to this bug.