1061858 - [Cost Control][Usage app] Usage app disables Wifi tracking after exiting/launching Usage app

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Josh Schmitt [Joshs]]

Attachment: log.txt

Description:
The Wifi tracking is being disables after the user exits the usage app then re-launches the usage app

Repro Steps:
1) Update a Flame device to BuildID: 20140902040205
2) Turn on Cell Data and connect to a Wifi Network
3) Open Usage app
4) Proceed through the first time use
5) Enable tracking of both Moble and Wifi usage
6) Force close the Usage app
7) Launch Usage app
8) Repeat steps 6-7 until repro

Actual:
Wifi usage tracking disables after exiting/re-launching Usage app

Expected: 
Data does not change tracking after exiting the Usage app

Environmental Variables:
Device: Flame 2.1 Master
BuildID: 20140902040205
Gaia: 44bf2e3bc5ddea9db9a8c851bd353cb234aa883c
Gecko: c360f3d1c00d
Version: 34.0a1 (2.1 Master)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Notes:
Repro frequency: 5/10, 50%
See attached: screenshot logcat

Comment 1

[Josh Schmitt [Joshs]]

Attachment: Wifi_Tracking.png

Comment 2

[Peter Bylenga [:PBylenga]]

QAWanted for branch checks to confirm this is a regression.

Comment 3

[Cody Roesch [:croesch]]

This bug repro's on: Flame 2.1, Flame 2.0, Flame 1.4, OpenC 2.1

Actual Results: Wifi tracking in the Usage app is getting disabled occasionally when exiting the app completely.

Repro Rate: 5/10

Environmental Variables:
Device: Flame Master
BuildID: 20140901224717
Gaia: 44bf2e3bc5ddea9db9a8c851bd353cb234aa883c
Gecko: c360f3d1c00d
Version: 34.0a1 (Master) 
Firmware Version: v123
------------------------------------------------
Environmental Variables:
Device: Flame 2.0
BuildID: 20140901103053
Gaia: 449d8db9b3ea1f9262db822c37ef2143477172b7
Gecko: 40d74e0bbcf5
Version: 32.0 (2.0) 
Firmware Version: v123
------------------------------------------------
Environmental Variables:
Device: Flame 1.4
BuildID: 20140902105642
Gaia: 2ee5b00bfbb8a67a967094804390b4afce8ecf54
Gecko: 4ab16aed1410
Version: 30.0 (1.4) 
Firmware Version: v123
------------------------------------------------
Environmental Variables:
Device: Open_C Master
BuildID: 20140902120804
Gaia: 7e469783859785a8bd4bf02a802f32561c84be7b
Gecko: 372ce1f36116
Version: 35.0a1 (Master) 
Firmware Version: P821A10V1.0.0B06_LOG_DL

Comment 4

[Joshua Mitchell (Inactive)]

[Blocking Requested - why for this release]: Not a regression but I would nom anyway because this is losing user-set preferences and this is within the usage / cost control app which is something that can create a very poor UX because their $ can be involved.

Comment 5

[Marshall Culpepper [:marshall_law]]

This part of the log looks suspect:

9-02 11:49:07.368: E/GeckoConsole(1233): [JavaScript Error: "TypeError: model.axis.Y.get is not a function" {file: "app://costcontrol.gaiamobile.org/js/views/datausage.js" line: 484}]

Comment 6

[bhavana bajaj [:bajaj]]

(In reply to Joshua Mitchell [:Joshua_M] from comment #4)
> [Blocking Requested - why for this release]: Not a regression but I would
> nom anyway because this is losing user-set preferences and this is within
> the usage / cost control app which is something that can create a very poor
> UX because their $ can be involved.

Not a regression and since the issue is with WIFi and not data I am not leaning on blocking on this for 2.0. Although, this is ugly and something we should fix in 2.1 so NI Maria to help drive this for 2.1

Comment 7

[Marina Rodríguez [:mai]]

Attachment: patch v1.0

Hi Salva, 
would you mind reviewing the patch?
The bug is produced by a race condition on the startup of the datausage module. The mobile toggle produces a graphic refresh when the model is not expanded yet.

Regards

Comment 8

[Salvador de la Puente González [:salva]]

Comment on attachment 8488462 [details] [review]
patch v1.0

he patch looks nice and it seems to solve the problem but just to clarify: if I understood well, it seems the application was crashing before updating the buttons. Isn't it?

Comment 9

[Marina Rodríguez [:mai]]

The app crashes during the updating process launched by the mobile toggle.

Comment 10

[Marina Rodríguez [:mai]]

Master: 62817927d8edc03e5a130f574357309d83c36d85

Comment 11

[Marina Rodríguez [:mai]]

Comment on attachment 8488462 [details] [review]
patch v1.0

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Feature
[User impact] if declined: The data wifi graffic is not showed. This bug is reproducible the 50%.
[Testing completed]:Yes
[Risk to taking this patch] (and alternatives if risky): Low risk
[String changes made]:No

Comment 12

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/379e68fe729a684fa2fcddb30ea1e65508db73e1

Comment 13

[Coler]

This issue has been verified successfully on Flame2.1&2.2.
Reproducing rate: 0/5
See attachment: Verify_Flame_usage.mp4

Flame2.1 build version:
Gaia-Rev        dbaf3e31c9ba9c3436e074381744f2971e15c7bf
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/ebce587d2194
Build-ID        20141203001205
Version         34.0

Flame2.2 build version:
Gaia-Rev        725685831f5336cf007e36d9a812aad689604695
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/2c9781c3e9b5
Build-ID        20141203040207
Version         37.0a1

Comment 14

[Coler]

Attachment: Verify_Flame_usage.MP4

Comment 16

[yifan [:yifan][:yliao]]

Comment on attachment 8488462 [details] [review]
patch v1.0

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 1095353
[User impact] if declined: wifi usage limit functionality will be regarded as broken.
[Testing completed]:Yes, unit test for costcontrol passed 
[Risk to taking this patch] (and alternatives if risky): Low risk
[String changes made]: No

Comment 17

[bhavana bajaj [:bajaj]]

Comment on attachment 8488462 [details] [review]
patch v1.0

Keeping comment #6 in mind and given we have no potential uplifts happening on 2.0 at this point, I am minusing this. This will fixed on 2.0M and 2.1.

Comment 18

[Kai-Zhen Li [:seinlin][:kli]]

v2.0m: https://github.com/mozilla-b2g/gaia/commit/f49be5634050407c8977369ff5431974cf22b76c

Comment 19

[Shally Li（leave from Mozilla）]

According to the STR of Comment 0,this bug has been successfully verified on latest Woodduck v2.0.

Actual result: After exiting the Usage app,Wifi data usage is not changed tracking and still checked.
See attachment: verified_v2.0m.mp4
Reproduce rate: 0/20

Device: Woodduck 2.0 build(Pass)
Build ID               20150421050314
Gaia Revision          37e63db3af0f76fe9c71a4ce23aef9771491124f
Gaia Date              2015-04-12 07:28:35
Gecko Revision         be29567fc9b1467162a79a39ad7c5db3ac5b0582
Gecko Version          32.0
Device Name            jrdhz72_w_ff
Firmware(Release)      4.4.2
Firmware(Incremental)  1429563900
Firmware Date          Tue Apr 21 05:05:18 CST 2015

Comment 20

[Shally Li（leave from Mozilla）]

Attachment: verified_v2.0m.mp4