Closed
Bug 1061891
Opened 10 years ago
Closed 10 years ago
We can't check whether a nsMainThreadPtrHandle is null
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: Yoric, Assigned: Yoric)
References
Details
Attachments
(1 file, 1 obsolete file)
1.28 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
It is quite common to have a `nsMainThreadPtrHolder<someCallbackType>` that we want to dispatch to the main thread iff it is not null. At the moment, doing this is quite clumsy. However, I believe that we could easily add a method `isNull()` that would simplify things.
Assignee | ||
Updated•10 years ago
|
Summary: nsMainThreadPtrHolder should have a method isNull() → We can't check whether a nsMainThreadPtrHandle is null
Assignee | ||
Comment 1•10 years ago
|
||
Assignee: nobody → dteller
Attachment #8486343 -
Flags: review?(bobbyholley)
Updated•10 years ago
|
Attachment #8486343 -
Flags: review?(bobbyholley) → review+
Assignee | ||
Comment 2•10 years ago
|
||
Try: https://tbpl.mozilla.org/?tree=Try&rev=82e3df1419ff
Assignee | ||
Comment 3•10 years ago
|
||
I just realized that we can mark this `operator!` as `const`, so I did. Try: https://tbpl.mozilla.org/?tree=Try&rev=82e3df1419ff
Attachment #8486343 -
Attachment is obsolete: true
Attachment #8487819 -
Flags: review?(bobbyholley)
Updated•10 years ago
|
Attachment #8487819 -
Flags: review?(bobbyholley) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Try: https://tbpl.mozilla.org/?tree=Try&rev=82e3df1419ff
Keywords: checkin-needed
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/fd23aa1410fb
Keywords: checkin-needed
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/fd23aa1410fb
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in
before you can comment on or make changes to this bug.
Description
•