1061914 - Do not hardcode CDN mozorg.cdn.mozilla.net

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Code Quality, defect, P3)

Description

[Andreas Wagner [:TheOne] [use NI]]

Hardcoding the CDN the way we currently do breaks dev instances if you access them via http as the CDN is CSP whitelisted via https only.

~/mozilla/olympia $ grep -R "mozorg.cdn" *
templates/impala/base.html:    <link href="//mozorg.cdn.mozilla.net/media/css/tabzilla-min.css" rel="stylesheet" />
templates/impala/base.html:    <script src="//mozorg.cdn.mozilla.net/{{ LANG }}/tabzilla/tabzilla.js"></script>
templates/base.html:           <link href="//mozorg.cdn.mozilla.net/media/css/tabzilla-min.css" rel="stylesheet" />
templates/base.html:           <script src="//mozorg.cdn.mozilla.net/{{ LANG }}/tabzilla/tabzilla.js"></script>

(irrelevant results removed)

Comment 1

[Andreas Wagner [:TheOne] [use NI]]

Can we just

s/=/=https:\/\//

ie insert https:// as I don't see that olympia contains tabzilla?

Comment 2

[Olivier Meunier [:aspyrine]]

(In reply to Andreas Wagner [:TheOne] from comment #1)
> Can we just
> 
> s/=/=https:\/\//

As suggested, I changed scheme to https in https://github.com/mozilla/olympia/pull/310

Comment 3

[Christopher Van Wiemeersch [:cvan]]

Merged: https://github.com/mozilla/olympia/commit/f2c4060

Thanks!

Also, we should probably do this for optimizely now:

https://github.com/mozilla/olympia/blob/f2c4060fe/templates/base.html#L44
https://github.com/mozilla/olympia/blob/f2c4060fe/templates/impala/base.html#L43

I can file a separate bug if you'd wish.

Comment 4

[Olivier Meunier [:aspyrine]]

(In reply to Christopher Van Wiemeersch [:cvan] from comment #3)
> I can file a separate bug if you'd wish.

I would take care of this right now, don't bother with another bug :)

Comment 5

[Olivier Meunier [:aspyrine]]

> I would take care of this right now, don't bother with another bug :)

Done https://github.com/mozilla/olympia/pull/312

Comment 6

[Christopher Van Wiemeersch [:cvan]]

Thanks again! Merged:
https://github.com/mozilla/olympia/commit/8497a03

Comment 7

[Madalin Cotetiu]

Please add STR here or mark it with [qa-] if no QA is needed.

Comment 8

[Olivier Meunier [:aspyrine]]

1/ Open https://addons-dev.allizom.org/fr/firefox/
2/ View the page source
3/ Check that URLs for mozorg.cdn.mozilla.net start with "https://"
4/ Check that URLs for cdn.optimizely.com start with "https://"

Comment 9

[Madalin Cotetiu]

Verified as fixed in FF32(Win7) in marketplace-dev.allizom.org
Postfix screencast: http://screencast.com/t/r0wyCZoULk
Closing.