1061983 - 'open' is hardcoded on lockscreen

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Théo Chevalier]

Attachment: Flame 2.1

Looks like we have a hardcoded string, https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/lockscreen_notification_builder.js#L103

2.1 is affected, so adding late-l10n as we are past FL (final string freeze is in two weeks).

Comment 1

[Théo Chevalier]

Attachment: Master PR

Note: I didn't test on device yet

Comment 2

[Théo Chevalier]

Also, looks like the string is not capitalized, regarding the UX spec https://mozilla.app.box.com/s/gsklu2bl6ii98sbn8bsk/1/2189547211/18997083751/1
Not sure if it's what we want

Comment 3

[Théo Chevalier]

Hi Rob,

Is the string 'open' or 'Open'? (Just to be sure)

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8483108 [details] [review]
Master PR

Thanks for catching the issue. Please redirect the next review to :snowmantw.

Comment 5

[Greg Weng [:snowmantw][:gweng][:λ]]

The spec in Bug 1023818 shows it's 'open' rather than 'Open'.

Comment 6

[Greg Weng [:snowmantw][:gweng][:λ]]

And maybe the patch can follow what Tim addressed at the GitHub page.

Comment 7

[Théo Chevalier]

Alright, thanks for the feedback, let's move on with 'open' :)

Comment 8

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8483108 [details] [review]
Master PR

Okay, it looks good and works on device

Comment 9

[Théo Chevalier]

Thanks Greg, setting checking keyword

Comment 10

[Carsten Book [:Tomcat]]

master: https://github.com/mozilla-b2g/gaia/commit/921e0d335137cd7cc8e963eedbb1669ea52e3ca5

Comment 11

[Théo Chevalier]

[Blocking Requested - why for this release]:
English string on lockscreen

Comment 12

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Théo, please set approval flag on the patch?

Comment 13

[Théo Chevalier]

Comment on attachment 8483108 [details] [review]
Master PR

oops, missed this change in uplift process

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 1043103
[User impact] if declined: English string on lockscreen when tapping on notification
[Testing completed]: Tested on 2.2, works fine in French
[Risk to taking this patch] (and alternatives if risky): very low
[String changes made]: Added one string to system.properties

Comment 14

[Francesco Lodolo [:flod]]

Out of curiosity: do we need approval on the patch when the bug is already marked as 2.1+?

Comment 15

[Axel Hecht [:Pike]]

(In reply to Francesco Lodolo [:flod] (offline from Aug 31 to Sep 7) from comment #14)
> Out of curiosity: do we need approval on the patch when the bug is already
> marked as 2.1+?

Yes, that's new in 2.1. YAY THAT!

Comment 16

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/6856bdfbcee7959672d7793891be731e3241d678

Comment 17

[KTucker [:KTucker][Inactive 3/4/2016]]

I verified that this issue is fixed using French on Flame 2.1(319mb) and on the Flame 2.2(319mb).

The string "Open" is translated properly. 

Flame 2.2

Environmental Variables:
Device: Flame Master (319mb)
Build ID: 20140908040204
Gaia: c71fd5d8c9c7cb021c97e5e9fbb29f92b50a084d
Gecko: 892768985915
Version: 35.0a1 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Flame 2.1

Environmental Variables:
Device: Flame 2.1(319mb)
Build ID: 20140908000204
Gaia: a8e4d26555e5713ec6c72270cfd0cfabc096a0d3
Gecko: 746f24f9d21d
Version: 34.0a2
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0