1061996 - [Camera] Switching between the Camera and Video buttons rapidly can disable them.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[John Thomas [:Johnt]]

Attachment: logcat_20140902_1524.txt

Description: After the user begins switching rapidly between the Video and Camera buttons the buttons will not be selectable.

Repro Steps:
1) Update a Flame to 20140902040205
2) Launce the Camera app
3) Press the Video and Camera toggle button Rapidly

Actual: The Camera and Video buttons become disabled.

Expected: It is expected that the Camera and Video buttons can still be selected even after switching quickly between the two.

Environmental Variables:
Device: Flame Master (319mb)
BuildID: 20140902040205
Gaia: 44bf2e3bc5ddea9db9a8c851bd353cb234aa883c
Gecko: c360f3d1c00d
Version: 34.0a1 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0


Repro frequency: 100%
See attached: Logcat, Video https://www.youtube.com/watch?edit=vd&v=79wbWpJWLxU

Comment 1

[John Thomas [:Johnt]]

This issue occurs on Flame 2.1 (512mb), Open_C 2.1

Description: Switching between the Camera and Video buttons rapidly can disable them.

Flame 2.1

Environmental Variables:
Device: Flame Master (512mb)
BuildID: 20140902040205
Gaia: 44bf2e3bc5ddea9db9a8c851bd353cb234aa883c
Gecko: c360f3d1c00d
Version: 34.0a1 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Open C 2.1

Environmental Variables:
Device: Open_C 2.1 Master
BuildID: 20140902040205
Gaia: 44bf2e3bc5ddea9db9a8c851bd353cb234aa883c
Gecko: c360f3d1c00d
Version: 34.0a1 (2.1 Master)
Firmware: P821A10v1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0


This issue does NOT occur on Flame 2.0 (319mb), Open_C 2.0

Result: The Camera and Video buttons become disabled.

Flame 2.0

Environmental Variables:
Device: Flame 2.0 (319mb)
BuildID: 20140902000202
Gaia: 449d8db9b3ea1f9262db822c37ef2143477172b7
Gecko: 40d74e0bbcf5
Version: 32.0 (2.0)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Open C 2.0

Environmental Variables:
Device: Open C 2.0
BuildID: 20140902000202
Gaia: 449d8db9b3ea1f9262db822c37ef2143477172b7
Gecko: 40d74e0bbcf5
Version: 32.0 (2.0)
Firmware Version: P821A10v1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 2

[KTucker [:KTucker][Inactive 3/4/2016]]

Your actual result does not make since for the branch that this issue does not occur on.

Comment 3

[John Thomas [:Johnt]]

Correcting my actual result for the devices this does NOT occur on.

his issue does NOT occur on Flame 2.0 (319mb), Open_C 2.0

Result: The Camera and Video buttons do NOT become disabled.

Flame 2.0

Environmental Variables:
Device: Flame 2.0 (319mb)
BuildID: 20140902000202
Gaia: 449d8db9b3ea1f9262db822c37ef2143477172b7
Gecko: 40d74e0bbcf5
Version: 32.0 (2.0)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Open C 2.0

Environmental Variables:
Device: Open C 2.0
BuildID: 20140902000202
Gaia: 449d8db9b3ea1f9262db822c37ef2143477172b7
Gecko: 40d74e0bbcf5
Version: 32.0 (2.0)
Firmware Version: P821A10v1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 4

[KTucker [:KTucker][Inactive 3/4/2016]]

[Blocking Requested - why for this release]:

This is a regression and the user should never lose functionality so nominating 2.1?

Comment 5

[Adam Alldredge [:AdamA][Inactive]]

Regressions Window:

Last working:
Device: Flame 2.1
BuildID: 20140723181705
Gaia: 15c84c943e41ad834640a45e1e1c2ac804168af7
Gecko: 66cb4d556959
Version: 34.0a1 (2.1)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

First Broken:
Device: Flame 2.1
BuildID: 20140723183605
Gaia: 5458f73e319759543fddf7e96d7ece4d78318e32
Gecko: 757608ac7f19
Version: 34.0a1 (2.1)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Last working Gaia First Broken Gecko: Issue does NOT reproduce
Gaia: 15c84c943e41ad834640a45e1e1c2ac804168af7
Gecko: 757608ac7f19

First Broken Gaia Last working Gecko: Issue DOES reproduce
Gaia: 5458f73e319759543fddf7e96d7ece4d78318e32
Gecko: 66cb4d556959

Gaia Pushlog:
https://github.com/mozilla-b2g/gaia/compare/15c84c943e41ad834640a45e1e1c2ac804168af7...5458f73e319759543fddf7e96d7ece4d78318e32

Caused by Bug 1038172

Comment 6

[Joshua Mitchell (Inactive)]

possibly broken by bug 1038172 - can you take a look Wilson?

Comment 7

[Hema Koka [:hema]]

Blocking Reason: Regression

Wilson, when you are back on Monday, please take a look.

Comment 8

[Wilson Page [:wilsonpage]]

Attachment: pull-request (master)

Comment 9

[Wilson Page [:wilsonpage]]

Comment on attachment 8485888 [details] [review]
pull-request (master)

LANDED https://github.com/mozilla-b2g/gaia/commit/5a23b2065e8669a855a66464837b05ced1f51f22

Comment 10

[Wilson Page [:wilsonpage]]

Comment on attachment 8485888 [details] [review]
pull-request (master)

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 1038172
[User impact] if declined: ? (ambiguous question)
[Testing completed]: ? (ambiguous question)
[Risk to taking this patch] (and alternatives if risky): Not risky
[String changes made]: None

Comment 11

[[:fabrice] Fabrice Desré]

(In reply to Wilson Page [:wilsonpage] from comment #10)
> Comment on attachment 8485888 [details] [review]
> pull-request (master)
> 
> [Approval Request Comment]
> [Bug caused by] (feature/regressing bug #): 1038172
> [User impact] if declined: ? (ambiguous question)

How is that ambiguous? What's broken from a user point of view without this patch?

> [Testing completed]: ? (ambiguous question)

Hu... is there any automated test? is that part of smoketests?

Comment 12

[Wilson Page [:wilsonpage]]

(In reply to Fabrice Desré [:fabrice] from comment #11)
> (In reply to Wilson Page [:wilsonpage] from comment #10)
> > Comment on attachment 8485888 [details] [review]
> > pull-request (master)
> > 
> > [Approval Request Comment]
> > [Bug caused by] (feature/regressing bug #): 1038172
> > [User impact] if declined: ? (ambiguous question)
> 
> How is that ambiguous? What's broken from a user point of view without this
> patch?

OK, I just found the wording confusing. 'The camera controls become unusable'

> > [Testing completed]: ? (ambiguous question)
> 
> Hu... is there any automated test? is that part of smoketests?

Unit-test in gaia-try? But the PR should show whether that passed or not. Am I missing something?

Comment 13

[[:fabrice] Fabrice Desré]

(In reply to Wilson Page [:wilsonpage] from comment #12)

> Unit-test in gaia-try? But the PR should show whether that passed or not. Am
> I missing something?

The PR doesn't show if there are new tests or not. For sure I can look at the patch itself (and here I did finally) but you're expected to make your case when requesting uplift ;)

Comment 14

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/6cb9de2c10070dc638ed9bc083ad5ff9a065db36

Comment 15

[Roland Kunkel [:RolandK]]

Verified as fixed for the latest 2.1 Flame build:

Environmental Variables:
----------------------------------------
Device: Flame 2.1
BuildID: 20141011000201
Gaia: f5d4ff60ffed8961f7d0380ada9d0facfdfd56b1
Gecko: d813d79d3eae
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Tapping on the camera / video toggle for 30+ seconds in rapid succession does not cause the camera app to become unresponsive. 

-

This issue is NOT fixed for the latest 2.2 Flame build:

Environmental Variables:
----------------------------------------
Device: Flame 2.2 Master
BuildID: 20141011040204
Gaia: 95f580a1522ffd0f09302372b78200dab9b6f322
Gecko: 3f6a51950eb5
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

In 3/5 attempts tapping on the camera / video toggle for 30+ seconds in rapid succession causes the camera app to become unresponsive.

https://bugzilla.mozilla.org/show_bug.cgi?id=1081570

Comment 16

[No-Jun Park [:njpark]]

Marking it back to verified since 2.2 issue is tracked by bug 1081570, and it is verified to be working in 2.1