1062046 - Intermittent failing test, TEST-UNEXPECTED-FAIL | /builds/slave/test/gaia/apps/system/test/marionette/notification_events_test.js | Notification events close event removes notification

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Evan Tseng [:evanxd]]

Intermittent failing test, TEST-UNEXPECTED-FAIL | /builds/slave/test/gaia/apps/system/test/marionette/notification_events_test.js | Notification events close event removes notification
The error log[1]:

17:40:14     INFO -    2) Notification events close event removes notification:
17:40:14     INFO -    ScriptTimeout: (28) timed out
17:40:14     INFO -    Remote Stack:
17:40:14     INFO -    <none>
17:40:14     INFO -        at Error.MarionetteError (/builds/slave/test/gaia/node_modules/marionette-client/lib/marionette/error.js:67:13)
17:40:14     INFO -        at Object.Client._handleCallback (/builds/slave/test/gaia/node_modules/marionette-client/lib/marionette/client.js:476:19)
17:40:14     INFO -        at /builds/slave/test/gaia/node_modules/marionette-client/lib/marionette/client.js:510:21
17:40:14     INFO -        at TcpSync.send (/builds/slave/test/gaia/node_modules/marionette-client/lib/marionette/drivers/tcp-sync.js:153:10)
17:40:14     INFO -        at Object.send (/builds/slave/test/gaia/node_modules/marionette-client/lib/marionette/client.js:457:36)
17:40:14     INFO -        at Object.Client._sendCommand (/builds/slave/test/gaia/node_modules/marionette-client/lib/marionette/client.js:503:19)
17:40:14     INFO -        at Object._executeScript (/builds/slave/test/gaia/node_modules/marionette-client/lib/marionette/client.js:1468:19)
17:40:14     INFO -        at Object.executeAsyncScript (/builds/slave/test/gaia/node_modules/marionette-client/lib/marionette/client.js:1249:19)
17:40:14     INFO -        at getHomescreen (/builds/slave/test/gaia/node_modules/marionette-apps/lib/launch.js:9:20)
17:40:14     INFO -        at launch (/builds/slave/test/gaia/node_modules/marionette-apps/lib/launch.js:47:23)
17:40:14     INFO -        at Context.<anonymous> (/builds/slave/test/gaia/apps/system/test/marionette/notification_events_test.js:118:17)
17:40:14     INFO -        at Test.Runnable.run (/builds/slave/test/gaia/node_modules/mocha/lib/runnable.js:196:15)
17:40:14     INFO -        at Runner.runTest (/builds/slave/test/gaia/node_modules/mocha/lib/runner.js:373:10)
17:40:14     INFO -        at /builds/slave/test/gaia/node_modules/mocha/lib/runner.js:451:12
17:40:14     INFO -        at next (/builds/slave/test/gaia/node_modules/mocha/lib/runner.js:298:14)
17:40:14     INFO -        at /builds/slave/test/gaia/node_modules/mocha/lib/runner.js:308:7
17:40:14     INFO -        at next (/builds/slave/test/gaia/node_modules/mocha/lib/runner.js:246:23)
17:40:14     INFO -        at /builds/slave/test/gaia/node_modules/mocha/lib/runner.js:270:7
17:40:14     INFO -        at done (/builds/slave/test/gaia/node_modules/mocha/lib/runnable.js:185:5)
17:40:14     INFO -        at /builds/slave/test/gaia/node_modules/mocha/lib/runnable.js:199:9
17:40:14     INFO -        at Object.executeHook (/builds/slave/test/gaia/node_modules/marionette-client/lib/marionette/client.js:369:18)
17:40:14     INFO -        at process._tickCallback (node.js:415:13)

[1] https://tbpl.mozilla.org/php/getParsedLog.php?id=47268125&full=1&branch=gaia-try#error1

Comment 1

[Ed Morley [:emorley]]

Adding keyword so this shows in TBPL's bug suggestions list.

Comment 2

[Evan Tseng [:evanxd]]

Ed, I will do that.
Thanks for your help. :D

Comment 3

[Michael Henretty [:mikehenrty][:mhenretty]]

This is one of the last failing intermittents on Gij. I'm going to take a look at this today.

Comment 4

[Michael Henretty [:mikehenrty][:mhenretty]]

> at getHomescreen (/builds/slave/test/gaia/node_modules/marionette-apps/lib/launch.js:9:20)

The timeout occurs when we try to launch the calendar app, and so marionette-apps.launch() attempts to fetch the homescreen URL from settings. For some reason the settings request neither resolves or errors [1]. I have a couple of ideas on how to solve this. But for now, I'm going to try and remove the calendar launch call, since it looks superfluous.

1.) https://github.com/mozilla-b2g/marionette-apps/blob/b242a28ffcd03778141a26b05e20dee406648f84/lib/launch.js#L9

Comment 5

[Michael Henretty [:mikehenrty][:mhenretty]]

Attachment: [Gaia PR] remove launch call

Let's run this a bunch of times, and see if it fixes it.

Comment 6

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8484290 [details] [review]
[Gaia PR] remove launch call

Yup, I think this fixes it. Re-running a bunch more times just to be sure. Kevin, wanna review this? If you don't feel comfortable I can find someone else.

Comment 7

[Kevin Grandon :kgrandon]

Comment on attachment 8484290 [details] [review]
[Gaia PR] remove launch call

Looks good to me, thanks!

Comment 8

[Michael Henretty [:mikehenrty][:mhenretty]]

I'm satisfied this is working. There was one notification_event_test error on gaia-try, but it was the infamous "Error: Not connected. To write data you must call connect first."

https://tbpl.mozilla.org/php/getParsedLog.php?id=47429664&tree=Gaia-Try&full=1#error4

Comment 9

[Michael Henretty [:mikehenrty][:mhenretty]]

https://github.com/mozilla-b2g/gaia/commit/6c844de438a58dbf7368e7a3ce0af1effcb21e7b

Comment 10

[:gerard-majax]

Nice one, michael. It may be worth that we recheck all notification testing code, I may have done the same mistake :)

Comment 11

[Michael Henretty [:mikehenrty][:mhenretty]]

(In reply to Alexandre LISSY :gerard-majax from comment #10)
> Nice one, michael. It may be worth that we recheck all notification testing
> code, I may have done the same mistake :)

Well, it's not really a mistake. Calling launch twice in a marionette test should be supported, and should not timeout when trying to get the homescreenUrl from settings. I filed bug 1063087 to workaround that issue for all marionette tests. Once that lands in gaia, we can probably re-enable bug 1061221.