1062089 - [jsdbg2] js/public/DebugAPI.h should be Debug.h

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jim Blandy :jimb]

Attachment: Rename js/public/DebugAPI.h to js/public/Debug.h. It's a public header file; *obviously* it's an API.

It's redundant to have header files in js/public named FooAPI.h.

Comment 1

[Jim Blandy :jimb]

Try push:
https://tbpl.mozilla.org/?tree=Try&rev=655e3c626bb7

Comment 2

[Nicholas Nethercote [inactive]]

We have:

> js/public/DebugAPI.h
> js/public/HeapAPI.h
> js/public/RootingAPI.h
> js/public/GCAPI.h
> js/public/OldDebugAPI.h
> js/public/TracingAPI.h

I'd suggest renaming all of them or none of them.

Comment 3

[Jim Blandy :jimb]

(In reply to Nicholas Nethercote [:njn] from comment #2)
> We have:
> 
> > js/public/DebugAPI.h
> > js/public/HeapAPI.h
> > js/public/RootingAPI.h
> > js/public/GCAPI.h
> > js/public/OldDebugAPI.h
> > js/public/TracingAPI.h
> 
> I'd suggest renaming all of them or none of them.

I looked into that. Terrence pointed out that we also have js/src/gc/Heap.h and js/src/gc/Rooting.h, and asked that we keep the "API" suffixes on those headers.

Comment 4

[Jason Orendorff [:jorendorff]]

Comment on attachment 8483258 [details] [diff] [review]
Rename js/public/DebugAPI.h to js/public/Debug.h. It's a public header file; *obviously* it's an API.

Review of attachment 8483258 [details] [diff] [review]:
-----------------------------------------------------------------

Would greatly appreciate a patch for everything.

In cases where we have both internal and public files that want the same name, the public one should get the nice name and we should ugly up the internal one (with something stupid like an Impl).

Comment 5

[Jim Blandy :jimb]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ff5de7f70414

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ff5de7f70414