Closed Bug 1062116 Opened 7 years ago Closed 7 years ago

MediaDecoderStateMachine::FlushDecoding() should call AssertCurrentThreadInMonitor()

Categories

(Core :: Audio/Video, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: jwwang, Assigned: jwwang)

Details

Attachments

(1 file)

It is wrong to call |mDecoder->GetReentrantMonitor().AssertNotCurrentThreadIn()| instead. Since AssertNotCurrentThreadIn() is not implemented at all, so we are still fine with the wrong statement.
See commment 0.
Assignee: nobody → jwwang
Status: NEW → ASSIGNED
See comment 0.
Attachment #8483300 - Flags: review?(kinetik)
Try: https://tbpl.mozilla.org/?tree=Try&rev=9d143fb82dc5
A simple Try on Linux debug to ensure to I didn't get it wrong.
Attachment #8483300 - Flags: review?(kinetik) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b7d2c160e1f0
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.