Closed Bug 1062138 Opened 7 years ago Closed 7 years ago

Mozmill cannot open NSS3 dylib due to changes on bug 1047728

Categories

(Testing Graveyard :: Mozmill, defect)

All
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

(Whiteboard: [mozmill-2.0.7+])

Attachments

(1 file)

With bug 1047728 we get some major changes for Firefox builds on OS X. It will move all the Resources from Contents/MacOS into Contents/Resources. That means that only binaries remain in Contents/MacOS. At the same time the GreD constant gets updated to point to Contents/Resources now.

We have to find a constant to use, which gives us the executable path.
As rstrong mentioned on IRC we should better use "XREExeF" here. After stripping the binary file name, we can append the dylib file name.
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Whiteboard: [mozmill-2.0.7] → [mozmill-2.0.7+]
Attachment #8483391 - Flags: review?(cmanchester)
Comment on attachment 8483391 [details] [diff] [review]
Usage of XREExeF v1

Review of attachment 8483391 [details] [diff] [review]:
-----------------------------------------------------------------

Trusting comment 1 and that this passes any sanity checks you've done (I haven't checked out the code and tested myself), this looks good to me.
Attachment #8483391 - Flags: review?(cmanchester) → review+
Yes, this has been tested for current builds and for the test build as located here:
http://people.mozilla.org/~spohl/FirefoxNightly.app.zip

I will land it later today.
Landed on both the master and hotfix-2.0 branch:
https://github.com/mozilla/mozmill/commit/8d2149e5bcab5270aa8fd3e6f58b426593c0dcd6 (master)
https://github.com/mozilla/mozmill/commit/3f469f45232215847f69af70795d9e2fb170da0d (hotfix-2.0)
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.