106221 - Deprecate use of setAttribute for event handlers

Status: NEW

(Core :: XUL, enhancement)

Description

[[e-mail]]

Although setAttribute can be used to dynamically add event handlers to XUL
elements there is no obvious way to remove such a handler (removeAttribute
doesn't seem to work, see comment in editor.js) and when the handler is already
a JS function this wastes an extra compile. IMHO this use of setAttribute should
be deprecated in favour of addEventListener (with the advantage of having
removeEventListener).

Comment 1

[David Hyatt]

--> default owner

Comment 2

[John Morrison]

Is there anything specifically to be done, code-wise, for this bug? Or is this
a request for hyatt (now jag) to admonish developers with an official "Don't
Do That!". :-)

Comment 3

[[e-mail]]

I'll settle for an admonishment from anyone that developers are prepared to
listen to, although I would prefer to remove any existing examples.

Comment 4

[jag (Peter Annema)]

Got a patch?

This should already be on (super-)reviewers' don't do that lists.