1062211 - Rename or delete the unused resources/*.json

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P3)

Description

[Ed Morley [:emorley]]

In bug 1046225 there was confusion about:
https://github.com/mozilla/treeherder-ui/blob/master/webapp/app/resources/menu.json

The file there is only sample data, but yet the filename and filepath don't indicate this. Same applies to many of the other files in that directory:
https://github.com/mozilla/treeherder-ui/tree/master/webapp/app/resources

We should either:
1) Delete those files if they really are unused now.
2) Rename/move them to somewhere more obvious (sample-data/*) if they are (or will be) used by tests.

Comment 1

[Jeffrey Godwyll [:jeffgodwyll] (away until Dec 15th - use "needinfo")]

Will like to be assigned this

Comment 2

[Ed Morley [:emorley]]

Have set you as the assignee.

You'll want to needinfo :camd to see what is the best thing to do with these (choices in comment 0).

Comment 3

[Jeffrey Godwyll [:jeffgodwyll] (away until Dec 15th - use "needinfo")]

I implemented some options from comment 0. Can you take a look if it's ok --> https://github.com/jeffgodwyll/treeherder-ui/commit/88388285f54b30c3917d5343b9e59561936a1833

https://github.com/mozilla/treeherder-ui/pull/149

Comment 4

[Cameron Dawson [:camd]]

Jeffrey - I think some changes to controllers/jobs.js got in there that are unrelated to the removal of the other files.  Could you back-out the changes to that file?  Then I'd say we're good to merge this.

Thanks!!!

Comment 5

[Ed Morley [:emorley]]

You may be able to solve this with rebasing on master and force pushing, which should get github showing the correct diff.

Comment 6

[Jeffrey Godwyll [:jeffgodwyll] (away until Dec 15th - use "needinfo")]

Thanks for the help. Will learn to use more of branches going forward. :). I just cleaned up the mess

https://github.com/mozilla/treeherder-ui/pull/189

Comment 7

[Jeffrey Godwyll [:jeffgodwyll] (away until Dec 15th - use "needinfo")]

Attachment: moved unused resources/*json to sample-data

Comment 8

[Ed Morley [:emorley]]

Comment on attachment 8490456 [details] [review]
moved unused resources/*json to sample-data

Requesting review on behalf of Jeffrey :-)

Comment 9

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/4ae26f29f31d0db5f48d7bcfd49e3dc39772dd65
Bug 1062211 - moved unused resources/*json to sample-data

https://github.com/mozilla/treeherder-ui/commit/de21e86f129764ca12da3528258b577d2f334428
Merge pull request #189 from jeffgodwyll/dev

Bug 1062211 - moved unused resources/*json to sample-data

Comment 10

[Ed Morley [:emorley]]

Thank you for sorting this :-)

Comment 11

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/e6e0eeed42dec7cb138e740eb48a5d6d14757dde
Bug 1062211 - moved unused resources/*json to sample-data

https://github.com/mozilla/treeherder/commit/097a19b7e3c5a7f51fceb9664760c414c6134baa
Merge pull request #189 from jeffgodwyll/dev

Bug 1062211 - moved unused resources/*json to sample-data