Improve the design of the »What is this« bubble on about:newtab

VERIFIED FIXED in Firefox 33

Status

()

defect
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: phlsa, Assigned: Mardak)

Tracking

33 Branch
Firefox 35
Points:
3
Dependency tree / graph
Bug Flags:
firefox-backlog +
qe-verify +

Firefox Tracking Flags

(firefox33+ verified, firefox34+ verified, firefox35 verified)

Details

Attachments

(8 attachments, 2 obsolete attachments)

The "double-doorhanger" isn't fit for release in its current form.

Instead, we would like to display just a single doorhanger from the browser icon with the text we need to display. There will also be styling tweaks.

An updated comp is attached.
Assignee: nobody → edilee
Flags: firefox-backlog?
Hardware: x86 → All
Flags: firefox-backlog? → firefox-backlog+
Flags: qe-verify?
Flags: qe-verify? → qe-verify+
PROPOSED SOLUTION:

Please take the link to "What it this page?" out of the cog menu, and place by itself next to the icon.

First fun, dropdown would appear automatically. Thereafter, the user clicks the link to show the message.

I'm attaching an example now...
First Run
Link stays in place thereafter.
(In reply to Aaron from comment #1)
> PROPOSED SOLUTION:
> 
> Please take the link to "What it this page?" out of the cog menu, and place
> by itself next to the icon.
> 
> First fun, dropdown would appear automatically. Thereafter, the user clicks
> the link to show the message.

This works for me, keeps the same level of interactions we agreed on previously so I don't think there's an issue to get this reviewed.
Looks good! But would that mean that the "what is this page" link would stay there forever or will it eventually disappear?

Also confirming: we are still planning to uplift this to 33 before it goes to release, right?
For now, there are no plans to remove the link.
(In reply to Aaron from comment #6)
> For now, there are no plans to remove the link.

OK. We might want to reconsider this at some point, since the link becomes less valuable over time. But I'm perfectly fine with keeping it visible for a couple of version.

Perhaps we can even use it for general tiles/product announcements in the future.
Agreed. And to clarify - no plans to remove the link UNTIL legal gives us the "ok" ;)
And that's why I couldn't find this bug in the new tab page component...

(In reply to Philipp Sackl [:phlsa] from comment #7)
> (In reply to Aaron from comment #6)
> > For now, there are no plans to remove the link.
> 
> OK. We might want to reconsider this at some point, since the link becomes
> less valuable over time. But I'm perfectly fine with keeping it visible for
> a couple of version.
> 
> Perhaps we can even use it for general tiles/product announcements in the
> future.

The requirement is that people can continue to find the link to our privacy notice.  That link may not matter as much in time but for now it is our requirement.  You could certainly transition the "What's this Page?" link from where it is into something like a footer or alternate location after a while.
Component: General → New Tab Page
Bryan, you just made this block a follow-up bug. Does that mean that we don't track it for 33 anymore?
That would be really sad since that version jump is when most people will see the much-dreaded double bubble.
(In reply to Philipp Sackl [:phlsa] from comment #10)
> Bryan, you just made this block a follow-up bug. Does that mean that we
> don't track it for 33 anymore?
> That would be really sad since that version jump is when most people will
> see the much-dreaded double bubble.

No, take that action as "i'm trying to track the followup bugs".  This can still track 33
Posted image v1 screenshot (obsolete) —
Posted patch v1Splinter Review
Attachment #8494961 - Attachment is obsolete: true
Attachment #8494986 - Flags: review?(adw)
Posted image v1 screenshot
The text still needs some additional styling, but this looks great! Thank you for getting this done, Ed.
Comment on attachment 8494986 [details] [diff] [review]
v1

Review of attachment 8494986 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/newtab/newTab.xul
@@ +89,5 @@
>        <div id="newtab-margin-bottom"/>
>  
>      </div>
>  
> +    <xul:hbox id="newtab-intro-what">&newtab.customize.what;</xul:hbox>

Does this really need to be an hbox?  Tim has already started converting newtab to e10s message passing, and one of the next steps is to convert the page to HTML, so ideally we wouldn't add any more XUL unless necessary.  At the same time though, this change is so small it's not a huge deal.
Attachment #8494986 - Flags: review?(adw) → review+
(In reply to Drew Willcoxon :adw (Away 9/29–10/14) from comment #16)
> > +    <xul:hbox id="newtab-intro-what">&newtab.customize.what;</xul:hbox>
> Does this really need to be an hbox?
Duhh. Sorry. I was copy/pasting the existing hbox/label and forgot the rest was html already. Switched to div. Thanks!

https://hg.mozilla.org/integration/fx-team/rev/a63ecf76aaa6
Points: --- → 3
Target Milestone: --- → Firefox 35
https://hg.mozilla.org/mozilla-central/rev/a63ecf76aaa6
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Iteration: --- → 35.2
Attachment #8496363 - Attachment description: for uplift → for beta uplift
Comment on attachment 8496363 [details] [diff] [review]
for beta uplift

Approval Request Comment
[Feature/regressing bug #]: Bug 1030832 / Enhanced Tiles
[User impact if declined]: Intro panel appears from customize panel appearing from customize button is too many levels of panels
[Describe test coverage new/current, TBPL]: None
[Risks and why]: Low - Tweaks to css and some html node reorganizing
[String/UUID change made/needed]: None
Attachment #8496363 - Flags: approval-mozilla-beta?
Comment on attachment 8496369 [details] [diff] [review]
for aurora uplift

Approval Request Comment
[Feature/regressing bug #]: Bug 1030832 / Enhanced Tiles
[User impact if declined]: Intro panel appears from customize panel appearing from customize button is too many levels of panels
[Describe test coverage new/current, TBPL]: None
[Risks and why]: Low - Tweaks to css and some html node reorganizing
[String/UUID change made/needed]: None
Attachment #8496369 - Flags: approval-mozilla-aurora?
Comment on attachment 8496363 [details] [diff] [review]
for beta uplift

Taking because the tiles are a new feature of Firefox 33 and quite visible.
Attachment #8496363 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #8496369 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
I missed an aspect when uplifting to beta in that the link appears outside the menu, which isn't shown on beta, so as the code is now, the link is still shown even on disabled locales.

We'll need additional code to do the hiding (only for beta as only beta has the flag to turn off enhanced tiles).
Posted patch extra beta uplift (obsolete) — Splinter Review
Attachment #8496576 - Flags: review?(adw)
QA Contact: cornel.ionce
Verified fixed on Windows 7 64-bit, Windows 8.1 64-bit, Ubuntu 12.04 and Mac OS X 10.9 using:
- latest Nightly, build ID: 20140928030206
- latest Aurora, build ID: 20140928004003

"What it this page?" button is now displayed next to the cog button.
Comment on attachment 8496576 [details] [diff] [review]
extra beta uplift

ttaubert, for some context, we landed some mozilla-beta specific code to turn off functionality on beta if we choose to turn off enhanced tiles:

Bug 1056279 - Turn off enhanced tiles feature for non-en-US Firefox 33 users
https://hg.mozilla.org/releases/mozilla-beta/rev/d9a70b065d65#l2.1

This bug moved a menu item from a menu that was not accessible for disabled users to outside of the menu, but I forgot to add logic to hide the now-outside-of-menu link for disabled users.
Attachment #8496576 - Flags: review?(adw) → review?(ttaubert)
Confirming this fix on Firefox 33 beta 8, build ID: 20140929180120.

User Agents:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:33.0) Gecko/20100101 Firefox/33.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0
Mozilla/5.0 (X11; Linux x86_64; rv:33.0) Gecko/20100101 Firefox/33.0
Status: RESOLVED → VERIFIED
Attachment #8496576 - Flags: review?(ttaubert) → review+
Approval Request Comment
[Feature/regressing bug #]: this bug 1062256
[User impact if declined]: Users see the introduction "what is this" link (as English text) even if we disable the enhanced tiles feature
[Describe test coverage new/current, TBPL]: https://tbpl.mozilla.org/?tree=Try&rev=8c7ecded425c
[Risks and why]: low - extra checked that things get disabled correctly even in english (for bug 1073823)
[String/UUID change made/needed]: none
Attachment #8496576 - Attachment is obsolete: true
Attachment #8497826 - Flags: approval-mozilla-beta?
Attachment #8497826 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0
Mozilla/5.0 (X11; Linux i686; rv:33.0) Gecko/20100101 Firefox/33.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0

Verified that the "What is this page" link is properly removed from Firefox 33 beta 9, build ID: 20141002185629 on Windows 7 64-bit, Ubuntu 12.04 32-bit and Mac OS X 10.9.5.
Depends on: 1081157
You need to log in before you can comment on or make changes to this bug.