106231 - add mnemonic for "Disable Quick Launch" in quick launch menu

Status: VERIFIED FIXED

(Core Graveyard :: QuickLaunch (AKA turbo mode), defect)

Description

[Tsukasa Maruyama]

"Disable Quick Launch" item when mozilla icon in windows taskbar right-clicked
is not have underline below first charactor "D".

It's key function is performed. why not have underline?

need to simple change
http://lxr.mozilla.org/mozilla/source/xpfe/browser/resources/locale/en-US/turboMenu.properties
- Disable=Disable Quick Launch
+ Disable=&Disable Quick Launch

Comment 1

[Bill Law]

Attachment: very simple patch, as suggested

I'm going to look into why the mnemonic/accelerator keys aren't indicated in
the menu.

Comment 2

[Bill Law]

It looks like the lack of underscores under the mnemonics is a Windows issue.  
I can't see any way to turn them on/off and I can't spot any sys tray icons 
that show the mnemonics.  So I think it just can't be done.

Comment 3

[Stephen P. Morse]

Comment on attachment 59789 [details] [diff] [review]
very simple patch, as suggested

r=morse

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 59789 [details] [diff] [review]
very simple patch, as suggested

sr=[e-mail]

Comment 5

[Bill Law]

fixed

Comment 6

[Blake Ross]

Bill, you probably have "Hide underlined letters for keyboard navigation until 
I press the Alt key" (or at least, that's the wording in Windows XP) checked in 
the Display prefs. I think that's the default in win2k.  Of course, it's pretty 
flawed, since pressing Alt will dismiss an open menu (but it works for things 
like the actual buttons themselves in a menubar).

Comment 7

[Bill Law]

I did, but that doesn't solve the problem for systray icon menus.  It did cause
one of my systray icon menus to start showing the underscores (Symantec PC
Anywhere).  But none of the others (including Mozilla) show them.

I gave up trying to figure out why.  Maybe Symantec PCAnywhere is doing
owner-draw menus or something.

Comment 8

[Grace Bush]

verified on build 2001120303