1062312 - The callscreen was not assigned the critical mozapptype when it was split from the communications apps

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Gabriele Svelto [:gsvelto] (PTO)]

+++ This bug was initially created as a clone of Bug #990003 +++

While reading the description of a couple of other bugs (namely bug 1056493 and bug 1055299) I realized that when we split the callscreen from the communications app we didn't adjust the system app to properly give it the critical mozapptype attribute.

This causes two separate issues:

- When the callscreen grabs the cpu/highpriority wakelock it doesn't get the priority boost it excepts. This is particularly bad because it affects it when we get an incoming call which is the most critical scenario I can think of priority-wise.

- When the communications apps grab the cpu/highpriority wakelock (usually to boost their OOM_ADJ score while saving something into a db) they get a huge priority boost which they shouldn't be getting. This was probably part of the cause of bug 1056493.

Comment 1

[Gabriele Svelto [:gsvelto] (PTO)]

Attachment: [PATCH] Add the 'critical' mozapptype attribute to the callscreen, not the dialer

This patch ensures that the 'critical' mozapptype attribute is not assigned anymore to the communications/dialer app but instead to the callscreen. This has no impact on the callscreen ATM because it lives in the system app but it does have an impact on the dialer and may solve the things-get-slow-after-launching-the-dialer bugs we've been seing. I made the callscreen change anyway so if/when it becomes a stand-alone app again it should get the correct prioritization.

Comment 2

[Gabriele Svelto [:gsvelto] (PTO)]

Attachment: [PULL REQUEST] Add the 'critical' mozapptype attribute to the callscreen, not the dialer

Comment 3

[bhavana bajaj [:bajaj]]

NI :gsvelto, do we need this in 2.0 ? I am not very sure about the risk/reward here, but checking as it was filed as a part of investigation in 1055299.

Comment 4

[Gabriele Svelto [:gsvelto] (PTO)]

(In reply to bhavana bajaj [:bajaj] from comment #3)
> NI :gsvelto, do we need this in 2.0 ? I am not very sure about the
> risk/reward here, but checking as it was filed as a part of investigation in
> 1055299.

Yes, this affects all versions starting with 1.4 (and 1.3T too actually).

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8485080 [details] [diff] [review]
[PATCH] Add the 'critical' mozapptype attribute to the callscreen, not the dialer

Review of attachment 8485080 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, thanks!

Comment 6

[Gabriele Svelto [:gsvelto] (PTO)]

Thanks for the review Alive! Pushed to gaia/master 26f80f0dd82343e158386de1096e5de926740868

https://github.com/mozilla-b2g/gaia/commit/26f80f0dd82343e158386de1096e5de926740868

The green Try run is here:

https://tbpl.mozilla.org/?rev=8a05c38d66ba227d3c0a3f6c6ce56ee54a81a0ac&tree=Gaia-Try

I had to retrigger the B2G Desktop Linux x64 Debug python integration test because it turned out orange during the first run.

Comment 7

[Josh Cheng [:josh]]

Hi Ka-Zhen,
Could you try land this on 2.0M? Thanks!

Comment 8

[Kai-Zhen Li [:seinlin][:kli]]

v2.0m: https://github.com/mozilla-b2g/gaia/commit/ae8c75d48318ee02226bcc08b38bd8625f6f17da

Comment 10

[Gregor Wagner [:gwagner]]

Putting on Kevins radar for 2.1 triage. It seems a critical issue.

Comment 11

[Josh Cheng [:josh]]

Triage:
Hi Vincent,
Kevin and Keven has approved to land this on 2.1.
Can you help to see whether the patch is able to land on 2.1? Thanks!

Comment 12

[Josh Cheng [:josh]]

Hi Gabriele,
Could you help to raise patch approval for landing on 2.1?
Thanks!

Comment 13

[Gabriele Svelto [:gsvelto] (PTO)]

Attachment: [PATCH v2.1] Add the 'critical' mozapptype attribute to the callscreen, not the dialer

This is a cherry-picked patch that applies cleanly to the v2.1 branch, only one minor conflict was fixed.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 990003
[User impact] if declined: Applications slowed down or were killed when the contacts/dialer app was recently launched, bug 1056493 and bug 1055299 are two examples
[Testing completed]: This has been on master for while and was repeatedly tested
[Risk to taking this patch] (and alternatives if risky): None
[String changes made]: None

Comment 14

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/80723acb60dedb2bcdf8a2276586f3b0cbe3d204