1062317 - tutorial-bookmark-migration-tiny string landed with the wrong text

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[Théo Chevalier]

The string landed with the same text as for tutorial-rocketbar-tiny in https://github.com/mozilla-b2g/gaia/commit/9898725d271d652207c469385b5f1931c8d1a27c

It should rather be:
Your bookmarks have been moved to the homescreen. When editing, tap a bookmark
to edit or rename it.

(As per spec https://bug938279.bugzilla.mozilla.org/attachment.cgi?id=8465126 )

Needs to be fixed on 2.1, will provide a PR

Comment 1

[Théo Chevalier]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23679

Francisco, could you give it a small review for this trivial patch please?
Thanks!

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

[Blocking Requested - why for this release]:

Part of a committed feature

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8483503 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23679

LGTM, r+

Comment 4

[Candice Serran (:cserran)]

Confirmed blocker: Text is incorrect for first time experience. Critical to user experience.

Comment 5

[Théo Chevalier]

Thanks, setting checking keyword

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/1ac3a57aa7a1bd7720ec52c5db29155d7dfe7b04

Comment 7

[Théo Chevalier]

Comment on attachment 8483503 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23679

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 938279
[User impact] if declined: Wrong text in FTE after upgrading
[Testing completed]: green try
[Risk to taking this patch] (and alternatives if risky): very low
[String changes made]: Updating one string in ftu

Comment 8

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/1d14eff9ca9d8a4bfb35156536022c0c83c77c05

Comment 9

[Kevin Grandon :kgrandon]

I don't think a test is needed for this string-only change. If we were to add a test it would just check for the l10n key as checking for actual content is fragile and probably not worth the effort. We just need to be more careful in the future here when adding new strings.

If someone disagrees with me we can re-visit the decision to add a test.

Comment 10

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame 2.1.

Result: After OTA upgrade from Flame 2.0, the string "Your bookmarks have been moved to the homescreen. When editing, tap a bookmark to edit or rename it" appeared properly during the tutorial page.

Environmental Variables:
Device: Flame 2.1
BuildID: 20141111001201
Gaia: 7154f9aa0a69af56c8bd89be0c98d9791449527b
Gecko: 452db1a0c9a0
Version: 34.0 (2.1)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
=========================================================

This issue is not verified on Flame 2.2.

Result: After OTA upgrade from Flame 2.0, the string "Your bookmarks have been moved to the homescreen. When editing, tap a bookmark to edit or rename it" did not appear during the tutorial page. The 4 regular FTU tutorial pages were presented.

Device: Flame 2.2 Master
BuildID: 20141111040202
Gaia: 6af3a8a833eb8bb651e8b188cb3f3c3a43bb4184
Gecko: 76b85b90a8cb
Version: 36.0a1 (2.2 Master)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Theo, is this an acceptable result? Is that valid to verify from 2.0 to 2.2 to get the string?

Comment 11

[Théo Chevalier]

(In reply to Yeojin Chung [:YeojinC] from comment #10)
> Theo, is this an acceptable result? Is that valid to verify from 2.0 to 2.2
> to get the string?

That's a different issue. This bug is about the text being wrong on the "Bookmarks migration" tutorial step, while what you're describing is that this step is missing with some update scenario.

I think you should file a new bug to update the FTU steps for 2.0->2.2 migration. I guess it's still the default FTU since 2.2 is not done yet, but filing a bug now would be good, so that people won't forget to include this step in 2.2 as well. Bookmark migration should be included while updating from 2.0 to 2.2.

I think what we want is:

1.1, 1.3, 1.4, 2.0 -> 2.1, 2.2: Display Bookmarks migration

2.1 -> 2.2: *Don't* display bookmark migration


Otherwise about this bug, the string looks good to me.

Comment 12

[Yeojin Chung [:YeojinC]]

(In reply to Théo Chevalier [:tchevalier] from comment #11)

Thanks! I'll verify 2.2, and filed a new bug 1104194.