1062353 - Firefox 31 mail.com partner build is not advertising updates

Status: RESOLVED FIXED

(Release Engineering :: Release Requests, defect)

Description

[Mike Kaply [:mkaply]]

The mail.com Firefox 31 build is not updating when  you go to the about dialog.

This is the update URL:

https://aus3.mozilla.org/update/3/Firefox/31.0/20140716183446/WINNT_x86-msvc/en-US/release-cck-mail.com/Windows_NT%206.1.1.0%20(x64)/mail.com/2.11.1/update.xml?force=1

Comment 1

[Chris Cooper [:coop] (he/him)]

bhearsum is in-transit to the SF office right now, but I'll get him to have a look once he's here.

Comment 2

[Rail Aliiev [:rail]]

It's interesting, http://mxr.mozilla.org/mozilla/source/webtools/aus/xml/inc/patch.class.php#365 won't let you have a dot as a part of a partner channel suffix. I wonder if this ever works for other partners with names not matching that pattern...

Comment 3

[Chris Cooper [:coop] (he/him)]

Rail discovered that if you replace 'release-cck-mail.com' with 'release-cck-mailcom' in the update URL, you get a valid snippet:

https://aus3.mozilla.org/update/3/Firefox/31.0/20140716183446/WINNT_x86-msvc/en-US/release-cck-mailcom/Windows_NT%206.1.1.0%20%28x64%29/mail.com/2.11.1/update.xml?force=1

Which leads to the question: have mail.com users *ever* been able to update previously?

I also want bhearsum to weigh in on how we will handle these custom builds in balrog.

Comment 4

[Mike Kaply [:mkaply]]

> Which leads to the question: have mail.com users *ever* been able to update previously?

That's a great question. If not, some testers have some explaining to do...

Comment 5

[Rail Aliiev [:rail]]

I just checked other partner configs and it looks like mail.com is the only one with a dot.

http://hg.mozilla.org/build/partner-repacks/rev/91e0b2b4867a#l3.9 is where it was changed.

Comment 6

[Mike Kaply [:mkaply]]

> http://hg.mozilla.org/build/partner-repacks/rev/91e0b2b4867a#l3.9 is where it was changed.

Argh.

We can change it back, but it leaves everyone stranded. Is there anything that can be done on the Mozilla end for now?

I'll change it back with the next release.

Thanks.

Comment 7

[Chris Cooper [:coop] (he/him)]

(In reply to Mike Kaply (:mkaply) from comment #6)
> > http://hg.mozilla.org/build/partner-repacks/rev/91e0b2b4867a#l3.9 is where it was changed.
> 
> Argh.
> 
> We can change it back, but it leaves everyone stranded. Is there anything
> that can be done on the Mozilla end for now?

Again, I'll defer to bhearsum on this because the balrog solution would likely be simpler, but we could probably generate snippets for both versions of the partner name pointing to the most recent version.

Comment 8

[Chris Cooper [:coop] (he/him)]

Attachment: Allow period in partner names

I don't see any harm in allowing periods/dots in the partner name.

Comment 9

[Ben Bucksch (:BenB)]

Thanks, guys!

> I just checked other partner configs and it looks like mail.com is the only one with a dot.

Do you have any partner names with any other characters, aside from a-z _ - (and dots)?

Comment 10

[Chris Cooper [:coop] (he/him)]

(In reply to Ben Bucksch (:BenB) from comment #9) 
> Do you have any partner names with any other characters, aside from a-z _ -
> (and dots)?

A quick check of the partner distribution.ini files says 'no.'

Comment 11

[[e-mail] (:bhearsum)]

(In reply to Chris Cooper [:coop] from comment #3)
> Rail discovered that if you replace 'release-cck-mail.com' with
> 'release-cck-mailcom' in the update URL, you get a valid snippet:
> 
> https://aus3.mozilla.org/update/3/Firefox/31.0/20140716183446/WINNT_x86-msvc/
> en-US/release-cck-mailcom/Windows_NT%206.1.1.0%20%28x64%29/mail.com/2.11.1/
> update.xml?force=1
> 
> Which leads to the question: have mail.com users *ever* been able to update
> previously?
> 
> I also want bhearsum to weigh in on how we will handle these custom builds
> in balrog.

We support fallback channels much in the same way we do with AUS2/3. I looked at the code briefly, and I don't see any possibility of similar issues -- the web framework handles splitting the URL into chunks, and the fallback channel logic (https://github.com/mozilla/balrog/blob/master/auslib/AUS.py#L25) doesn't have any regexes are other such thing that could be suceptible to this.

Comment 12

[Chris Cooper [:coop] (he/him)]

Comment on attachment 8486013 [details] [diff] [review]
Allow period in partner names

Review of attachment 8486013 [details] [diff] [review]:
-----------------------------------------------------------------

xebec:inc ccooper$ cvs commit
cvs commit: Examining .
Checking in patch.class.php;
/cvsroot/mozilla/webtools/aus/xml/inc/patch.class.php,v  <--  patch.class.php
new revision: 1.34; previous revision: 1.33
done
xebec:inc ccooper$ cvs tag -F -r 1.34 AUS2_PRODUCTION patch.class.php
T patch.class.php