Closed
Bug 1062355
Opened 10 years ago
Closed 9 years ago
Crash in d3dcompiler, nested-functions-should-not-crash.html test of WebGL Conformance Test
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
VERIFIED
FIXED
mozilla37
People
(Reporter: alice0775, Assigned: u480271)
References
()
Details
(Keywords: crash, crashreportid)
Crash Data
Attachments
(1 file)
1.28 KB,
patch
|
jgilbert
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
This bug was filed from the Socorro interface and is report bp-7507e59b-2f31-433d-b146-49ba52140903. ============================================================= Steps To Reproduce: 1. Open https://www.khronos.org/registry/webgl/sdk/tests/webgl-conformance-tests.html 2. Find "conformance/glsl/bugs/nested-functions-should-not-crash.html" 3. Click [run] of conformance/glsl/bugs/nested-functions-should-not-crash.html Actual Results: Browser crashes.
Comment 1•10 years ago
|
||
I also tried against FF34.0b8 and used d3dcompiler_47.dll (renamed to d3dcompiler_46.dll, placed in the Firefox folder). https://crash-stats.mozilla.com/report/index/bp-648ce59d-09fb-4fa8-8d8b-324a02141111
Comment 2•9 years ago
|
||
It still crashing on - https://www.khronos.org/registry/webgl/sdk/tests/conformance/glsl/bugs/nested-functions-should-not-crash.html?webglVersion=1 Crash report: https://crash-stats.mozilla.com/report/index/38663276-0b9e-4f13-a9a5-2391b2141204 https://crash-stats.mozilla.com/report/index/6949b0ed-f156-4a81-8e50-d4ea22141204 https://crash-stats.mozilla.com/report/index/29d9c47b-80d4-44dc-b034-1189b2141204 https://crash-stats.mozilla.com/report/index/a96becae-2bb0-4cb3-aacc-658e72141204
Crash Signature: [@ d3dcompiler_46.dll@0x111822] → [@ d3dcompiler_46.dll@0x111822]
[@ d3dcompiler_47.dll@0x1a3fd8 ]
[@ d3dcompiler_47.dll@0x1a3fd9 ]
Keywords: crashreportid
OS: Windows 7 → All
Hardware: x86 → All
Updated•9 years ago
|
Summary: crash in d3dcompiler_46.dll@0x111822 , nested-functions-should-not-crash.html test of WebGL Conformance Test → Crash in d3dcompiler, nested-functions-should-not-crash.html test of WebGL Conformance Test
Enable ANGLE compiler option to enable limiting call stack depth checks in the transpiler. Chromium Issue 238837 - https://code.google.com/p/chromium/issues/detail?id=238837: "This test causes a stack overflow in various GPU drivers."
Attachment #8533003 -
Flags: review?(jgilbert)
Updated•9 years ago
|
Attachment #8533003 -
Flags: review?(jgilbert) → review+
https://hg.mozilla.org/mozilla-central/rev/0fe752f786b3
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Comment on attachment 8533003 [details] [diff] [review] Enable SH_LIMIT_CALL_STACK_DEPTH Approval Request Comment [Feature/regressing bug #]: Bug 1062355 [User impact if declined]: Ill-formed WebGLSL can crash Firefox by causing the stack to be exhausted. [Describe test coverage new/current, TBPL]: Tested against WebGL Conformance suite as well as https://www.khronos.org/registry/webgl/sdk/tests/conformance/glsl/bugs/nested-functions-should-not-crash.html [Risks and why]: Low. Replace crash with WebGL error when compiling ill-formed source. [String/UUID change made/needed]:
Attachment #8533003 -
Flags: approval-mozilla-beta?
Attachment #8533003 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
Updated•9 years ago
|
Attachment #8533003 -
Flags: approval-mozilla-beta?
Attachment #8533003 -
Flags: approval-mozilla-beta+
Attachment #8533003 -
Flags: approval-mozilla-aurora?
Attachment #8533003 -
Flags: approval-mozilla-aurora+
Comment 8•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/1bc888409400 https://hg.mozilla.org/releases/mozilla-beta/rev/b044a73a2d5f
You need to log in
before you can comment on or make changes to this bug.
Description
•