Closed Bug 1062371 Opened 10 years ago Closed 10 years ago

Autophone - incorporate recent changes to mozdevice.adb

Categories

(Testing Graveyard :: Autophone, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bc, Assigned: bc)

References

Details

Attachments

(6 files)

jgraham has recently landed several changes to adb.py in mozdevice which need to be incorporated. There are several minor changes which need to be made to Autophone due to changes in method signatures.
Depends on: 1048942
Depends on: 1048883
Depends on: 1048881
Depends on: 1050896
Depends on: 1048889
Depends on: 1063886
has a trailing whitespace error on line 86 which we'll fix up in a later bug.
This applies on top of the patch in bug 1063886.
Attachment #8485679 - Flags: review?(mcote)
Comment on attachment 8485679 [details] [diff] [review] bug-1062371.patch Review of attachment 8485679 [details] [diff] [review]: ----------------------------------------------------------------- ::: phonetest.py @@ +71,3 @@ > logger_name='autophone.phonetest.adb', > device_ready_retry_wait=self.options.device_ready_retry_wait, > + device_ready_retry_attempts=self.options.device_ready_retry_attempts, Weird indenting. ::: worker.py @@ +181,3 @@ > logger_name='autophone.worker.adb', > device_ready_retry_wait=self.options.device_ready_retry_wait, > + device_ready_retry_attempts=self.options.device_ready_retry_attempts, Weird indenting.
Attachment #8485679 - Flags: review?(mcote) → review+
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: