Autophone - incorporate recent changes to mozdevice.adb

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: bc, Assigned: bc)

Tracking

Trunk
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(6 attachments)

(Assignee)

Description

4 years ago
jgraham has recently landed several changes to adb.py in mozdevice which need to be incorporated. There are several minor changes which need to be made to Autophone due to changes in method signatures.
(Assignee)

Updated

4 years ago
Depends on: 1048942
(Assignee)

Updated

4 years ago
Depends on: 1048883
(Assignee)

Updated

4 years ago
Depends on: 1048881
(Assignee)

Updated

4 years ago
Depends on: 1050896
(Assignee)

Updated

4 years ago
Depends on: 1048889
(Assignee)

Updated

4 years ago
Depends on: 1063886
(Assignee)

Comment 1

4 years ago
Created attachment 8485524 [details] [diff] [review]
1-bug-1048889.patch
(Assignee)

Comment 2

4 years ago
Created attachment 8485525 [details] [diff] [review]
2-bug-1050896.patch

has a trailing whitespace error on line 86 which we'll fix up in a later bug.
(Assignee)

Comment 3

4 years ago
Created attachment 8485526 [details] [diff] [review]
3-bug-1048881.patch
(Assignee)

Comment 4

4 years ago
Created attachment 8485527 [details] [diff] [review]
4-bug-1048883.patch
(Assignee)

Comment 5

4 years ago
Created attachment 8485528 [details] [diff] [review]
5-bug-1048942.patch
(Assignee)

Comment 6

4 years ago
Created attachment 8485679 [details] [diff] [review]
bug-1062371.patch

This applies on top of the patch in bug 1063886.
Attachment #8485679 - Flags: review?(mcote)

Comment 7

4 years ago
Comment on attachment 8485679 [details] [diff] [review]
bug-1062371.patch

Review of attachment 8485679 [details] [diff] [review]:
-----------------------------------------------------------------

::: phonetest.py
@@ +71,3 @@
>                                   logger_name='autophone.phonetest.adb',
>                                   device_ready_retry_wait=self.options.device_ready_retry_wait,
> +                                 device_ready_retry_attempts=self.options.device_ready_retry_attempts,

Weird indenting.

::: worker.py
@@ +181,3 @@
>                              logger_name='autophone.worker.adb',
>                              device_ready_retry_wait=self.options.device_ready_retry_wait,
> +                            device_ready_retry_attempts=self.options.device_ready_retry_attempts,

Weird indenting.
Attachment #8485679 - Flags: review?(mcote) → review+
You need to log in before you can comment on or make changes to this bug.