Autophone - allow fifo job ordering in addition to lifo

RESOLVED FIXED

Status

Testing
Autophone
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: bc, Assigned: bc)

Tracking

Trunk
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Currently Autophone processes jobs in lifo order. This is good for cases where we want the most recent builds processed quickly but can be a problem when attempting to identify regression windows quickly since testing the regressing changeset may be delayed by newer jobs. We should have a command line option to allow us to choose the order in which jobs are processed.
(Assignee)

Comment 1

3 years ago
Created attachment 8490822 [details] [diff] [review]
bug-1062378.patch

applies after bug 1037077
Attachment #8490822 - Flags: review?(mcote)

Comment 2

3 years ago
Comment on attachment 8490822 [details] [diff] [review]
bug-1062378.patch

Review of attachment 8490822 [details] [diff] [review]:
-----------------------------------------------------------------

This is fine, but do you think it might be better to have a proper priority scheme?  Like everything defaults to, say, 2, but you could insert a job with a priority 1 to get it processed first, or 3 to get it processed later.

::: jobs.py
@@ +124,5 @@
>              device = self.default_device
> +        if lifo:
> +            order = 'desc'
> +        else:
> +            order = 'asc'

Can simplify that into

order = 'desc' if lifo else 'asc'
Attachment #8490822 - Flags: review?(mcote) → review+
(Assignee)

Comment 3

3 years ago
I'm not sure of the use case for more generalized priorities.

The rationale for fifo is to allow us to process builds in order and therefore easily identify the first occurrence of regressions. The rationale for lifo, obsolete now for the most part, was to always keep up by processing the newest jobs first.

If we added a priority, we would still want to be able to make sure the jobs where either processed fifo or lifo within the priority I would think.
(Assignee)

Comment 4

3 years ago
https://github.com/mozilla/autophone/commit/c3df2d2a3d2a5127effc986593c8b2e19bc4a284
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.