1062447 - Gecko profiler doesn't store shared libraries breakpad ids in Linux

Status: RESOLVED DUPLICATE of bug 1061800

(Firefox OS Graveyard :: Infrastructure, defect)

Description

[Wander Lairson Costa]

Gecko profiler should read/calculate breakpad ids so it can get the correct symbols information from symbol server.

Comment 1

[Wander Lairson Costa]

Attachment: Add breakpad ids to profiler in Linux. r=BenWa

By default, breakpad uses the build-id section for ids, if it isn't
found, it uses the .text section. On the later case, the stripped
libraries will have different ids from their non-stripped counterparts.

See Bug 1062459 for details.

Comment 2

[Benoit Girard (:BenWa)]

Comment on attachment 8485111 [details] [diff] [review]
Add breakpad ids to profiler in Linux. r=BenWa

Review of attachment 8485111 [details] [diff] [review]:
-----------------------------------------------------------------

::: tools/profiler/shared-libraries-linux.cc
@@ +19,5 @@
> +#include <algorithm>
> +
> +#define ARRAY_SIZE(a) (sizeof(a)/sizeof(a[0]))
> +
> +static std::string getId(const char *bin_name)

Can we get a comment explaining what this is trying to do?

Comment 3

[Wander Lairson Costa]

Attachment: Add breakpad ids to profiler in Linux. r=BenWa

By default, breakpad uses the build-id section for ids, if it isn't
found, it uses the .text section. On the later case, the stripped
libraries will have different ids from their non-stripped counterparts.

See Bug 1062459 for details.

Comment 5

[Benoit Girard (:BenWa)]

Comment on attachment 8485152 [details] [diff] [review]
Add breakpad ids to profiler in Linux. r=BenWa

Review of attachment 8485152 [details] [diff] [review]:
-----------------------------------------------------------------

::: tools/profiler/shared-libraries-linux.cc
@@ +32,5 @@
> +  FileID file_id(bin_name);
> +  if (file_id.ElfFileIdentifier(identifier)) {
> +    FileID::ConvertIdentifierToString(identifier, id_str, ARRAY_SIZE(id_str));
> +    // remove dashes from the ID and append a trailing "0"
> +    return string(id_str, remove(id_str, id_str + strlen(id_str), '-')) + '0';

We should document why this step is needed.