Breakpad ids don't match for some stripped libraries

NEW
Unassigned

Status

Firefox OS
Infrastructure
P4
minor
3 years ago
3 years ago

People

(Reporter: wcosta, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

3 years ago
The current implementation of breakpad will look for a .note.gnu.build-id section and use that as the file id, otherwise it falls back to a simple hash of the .text section.

If there is no build-id, the full debug and stripped versions of a binary will differ.
(Reporter)

Updated

3 years ago
Status: NEW → ASSIGNED
(Reporter)

Comment 1

3 years ago
Dropping the priority because the bug actually happens only for a few binaries.
Severity: normal → minor
(Reporter)

Updated

3 years ago
Priority: -- → P4
(In reply to Wander Lairson Costa [:wcosta] from comment #0)
> The current implementation of breakpad will look for a .note.gnu.build-id
> section and use that as the file id, otherwise it falls back to a simple
> hash of the .text section.
> 
> If there is no build-id, the full debug and stripped versions of a binary
> will differ.

For which binaries is this a problem? Breakpad's implementation is explicitly intended to do the right thing in the face of stripping here, in that it's hashing the first page of .text, which should not be different between the stripped and unstripped binaries.
(Reporter)

Comment 3

3 years ago
Created attachment 8489392 [details]
lights.msm8610.so.debug
(Reporter)

Comment 4

3 years ago
Created attachment 8489393 [details]
lights.msm8610.so.stripped
(Reporter)

Comment 5

3 years ago
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #2)
> (In reply to Wander Lairson Costa [:wcosta] from comment #0)
> > The current implementation of breakpad will look for a .note.gnu.build-id
> > section and use that as the file id, otherwise it falls back to a simple
> > hash of the .text section.
> > 
> > If there is no build-id, the full debug and stripped versions of a binary
> > will differ.
> 
> For which binaries is this a problem? Breakpad's implementation is
> explicitly intended to do the right thing in the face of stripping here, in
> that it's hashing the first page of .text, which should not be different
> between the stripped and unstripped binaries.

I attached the stripped and debug versions of the library I have found the issue, but I haven't gone far on why this happens.
(Reporter)

Updated

3 years ago
Assignee: wcosta → nobody
Status: ASSIGNED → NEW
You need to log in before you can comment on or make changes to this bug.