It seems you can end up with two jobs styled as selected, with a particular workflow and possibly a particular OS (I am running EOL XP SP3). To reproduce o open production http://treeherder.mozilla.org o Click any job o Ctrl-click any _2nd job to pinboard it o Click again on that 2nd job Expected Behavior I think - the first job would get styled deselected when step 3) is invoked. Observed Both jobs appear selected. I checked in w/camd on IRC. Perhaps someone else can try on WinXP/7/8 to see if they can reproduce it or not, depending on their flavor of OS.
Summary: You can end up with two jobs selected with particular workflow (and/or OS) → You can end up with multiple jobs selected using Ctrl/Cmd click to pin
Created attachment 8638768 [details] multipleStyledSelected Noting also, it's possible to have more than two as originally reported. I suspect most users favor spacebar for pinning, based on the lack of complaints about this behavior.
I can confirm that the behavior is as described in comment 0, but I'm not exactly sure that's not the desired behavior. If you want to deselect JobA when you ctrl-click JobB, you probably want to select JobB at the same point it gets pinned. If you want to use ctrl-click to rapidly select multiple jobs, you'd then have to wait for job details to load for each job you click, adding significant delays to your clicking. Anyway, https://github.com/mozilla/treeherder/blob/0300fb69bad7223585fd9e9c885b5a159b292221/ui/js/directives/treeherder/clonejobs.js#L399-L403 is where these are controlled. If we want to fix this bug, we'd just need to also call clickJobCb() somewhere in/after togglePinJobCb().
Still happens. But pretty benign. On a mac, you use the option-click to do reproduce this.
Priority: P4 → P5
Assigning to Kiki as an Outreachy assessment.
Assignee: nobody → kikis.github
I was able to reproduce this both in production and locally on a mac with cmd-click. Fix forthcoming.
Created attachment 8916831 [details] [review] [treeherder] kikisdeliveryservice:Bug_1062463_Fix > mozilla:master
PR submitted, all Travis CI checks passed. Please let me know if you have any questions or comments.
Comment on attachment 8916831 [details] [review] [treeherder] kikisdeliveryservice:Bug_1062463_Fix > mozilla:master This works great! Would you now squash the commits and add the bug number to the single commit? Thanks! :)
Attachment #8916831 - Flags: review?(cdawson) → review+
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/55ad96672bfc66d82ac50cc377506a714d8dd075 Bug 1062463 - Correctly highlight/select jobs when adding to pinboard
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.