Closed
Bug 1062484
Opened 10 years ago
Closed 10 years ago
String.fromCodePoint.length should be 1
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: ljharb, Assigned: 446240525, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-complete)
Attachments
(1 file, 1 obsolete file)
|
2.67 KB,
patch
|
till
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_4) AppleWebKit/537.78.2 (KHTML, like Gecko) Version/7.0.6 Safari/537.78.2 Steps to reproduce: `String.fromCodePoint.length === 1` in the console Actual results: It returned false. Expected results: It should have returned true, per https://people.mozilla.org/~jorendorff/es6-draft.html#sec-string.fromcodepoint (implemented in https://bugzilla.mozilla.org/show_bug.cgi?id=918879)
|
||
Updated•10 years ago
|
Component: Untriaged → JavaScript Engine
Product: Firefox → Core
|
||
Comment 1•10 years ago
|
||
Confirmed, thanks. Also needs updates to the polyfill on MDN.
Blocks: es6
Mentor: till
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: dev-doc-needed
OS: Mac OS X → All
Hardware: x86 → All
Version: 31 Branch → Trunk
Attachment #8484188 -
Flags: review?(till)
Updated the polyfill on MDN.
Keywords: dev-doc-needed → dev-doc-complete
|
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8484188 [details] [diff] [review] bug1062484.patch Review of attachment 8484188 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, thanks for the extremely quick fix.
Attachment #8484188 -
Flags: review?(till) → review+
|
|
||
Comment 5•10 years ago
|
||
New version with slightly modified description. Inbound is closed, so I'll just set the checkin-needed flag in a minute. That'll cause a sheriff to land the patch once inbound is open again.
Attachment #8484188 -
Attachment is obsolete: true
Attachment #8484210 -
Flags: review+
|
|
||
Comment 6•10 years ago
|
||
Try-run here: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=e5d89e63c0d8
|
||
Comment 7•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/42428115fe70
Flags: in-testsuite+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/42428115fe70
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in
before you can comment on or make changes to this bug.
Description
•