1062490 - Array indexes in console.table() are sorted lexicographically

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Heather Arthur [:harth]]

console.table() an array of more than 10 things, then sort by their index by clicking on the first column in the output. You'll see:

0
1
10
2
3
...

It's sorting lexicographically. We should sort this column numerically.

Comment 1

[Heather Arthur [:harth]]

Gabriel, I think you already had a patch for this. If you do, can you upload it and flag for review? Otherwise no worries.

Comment 3

[Gabriel [:gl] (ΦωΦ)]

Attachment: 1062490.patch

https://tbpl.mozilla.org/?tree=Try&rev=b993a9840a11

Comment 4

[Heather Arthur [:harth]]

Comment on attachment 8484287 [details] [diff] [review]
1062490.patch

Thanks!

Comment 5

[Gabriel [:gl] (ΦωΦ)]

Comment on attachment 8484287 [details] [diff] [review]
1062490.patch

Approval Request Comment
[Feature/regressing bug #]: 1062490
[User impact if declined]: The index column for console.table() will be sorted incorrectly. This makes it appear as if console.table() is a WIP and not a completed feature.
[Describe test coverage new/current, TBPL]: Green try, minor changes to the test of indices in the previous tests which resulted in converting the string numeric values to actual integers.
[Risks and why]: None
[String/UUID change made/needed]: None

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/8733499c2f16

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8733499c2f16

Comment 8

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8484287 [details] [diff] [review]
1062490.patch

Aurora+

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/41e56fdebf65