1062515 - "DEPRECATION WARNING: Search service falling back to synchronous initialization" in SelectionHandler

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

Saw this in the logcat,

> E/GeckoConsole(18426): [JavaScript Error: "DEPRECATION WARNING: Search service falling back to synchronous initialization. This is generally the consequence of an add-on using a deprecated search service API.
> E/GeckoConsole(18426): You may find more details about this deprecation at: https://developer.mozilla.org/en-US/docs/XPCOM_Interface_Reference/nsIBrowserSearchService#async_warning
> E/GeckoConsole(18426): jar:jar:file:///data/app/org.mozilla.fennec_nchen-1.apk!/assets/omni.ja!/components/nsSearchService.js 2891 SRCH_SVC__ensureInitialized
> E/GeckoConsole(18426): jar:jar:file:///data/app/org.mozilla.fennec_nchen-1.apk!/assets/omni.ja!/components/nsSearchService.js 4106 SearchService.prototype.defaultEngine
> E/GeckoConsole(18426): chrome://browser/content/SelectionHandler.js 662 SelectionHandler.actions.SEARCH.label
> E/GeckoConsole(18426): chrome://browser/content/SelectionHandler.js 502 SelectionHandler._getValue
> E/GeckoConsole(18426): chrome://browser/content/SelectionHandler.js 538 SelectionHandler._updateMenu
> E/GeckoConsole(18426): chrome://browser/content/SelectionHandler.js 1168 sh_positionHandles
> E/GeckoConsole(18426): chrome://browser/content/SelectionHandler.js 343 sh_startSelection

See also bug 1017903 (different user of search service).

Comment 1

[:Margaret Leibovic]

(In reply to Jim Chen [:jchen :nchen] from comment #0)
> Saw this in the logcat,
> 
> > E/GeckoConsole(18426): [JavaScript Error: "DEPRECATION WARNING: Search service falling back to synchronous initialization. This is generally the consequence of an add-on using a deprecated search service API.
> > E/GeckoConsole(18426): You may find more details about this deprecation at: https://developer.mozilla.org/en-US/docs/XPCOM_Interface_Reference/nsIBrowserSearchService#async_warning
> > E/GeckoConsole(18426): jar:jar:file:///data/app/org.mozilla.fennec_nchen-1.apk!/assets/omni.ja!/components/nsSearchService.js 2891 SRCH_SVC__ensureInitialized
> > E/GeckoConsole(18426): jar:jar:file:///data/app/org.mozilla.fennec_nchen-1.apk!/assets/omni.ja!/components/nsSearchService.js 4106 SearchService.prototype.defaultEngine
> > E/GeckoConsole(18426): chrome://browser/content/SelectionHandler.js 662 SelectionHandler.actions.SEARCH.label
> > E/GeckoConsole(18426): chrome://browser/content/SelectionHandler.js 502 SelectionHandler._getValue
> > E/GeckoConsole(18426): chrome://browser/content/SelectionHandler.js 538 SelectionHandler._updateMenu
> > E/GeckoConsole(18426): chrome://browser/content/SelectionHandler.js 1168 sh_positionHandles
> > E/GeckoConsole(18426): chrome://browser/content/SelectionHandler.js 343 sh_startSelection
> 
> See also bug 1017903 (different user of search service).

Bug 1017903 isn't even fixed yet?!

This one is a little trickier because we'd have to change the logic around to make it async. At the very least we could avoid evaluating Services.search.defaultEngine.name until this label function is called:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/SelectionHandler.js?force=1#661

Comment 2

[:Margaret Leibovic]

You'll probably only run into this if the action bar is displayed before you ever type in the urlbar. So it's not quite as bad as bug 1017903, which happens during first page load.

Bug 927692 would also help with this.

Comment 3

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.