Closed
Bug 1062532
Opened 10 years ago
Closed 10 years ago
minor refactor of Settings->About->Updates code
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dietrich, Assigned: dietrich)
Details
Attachments
(1 file)
Some clean-up before fixing a couple of other bugs in that area.
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → dietrich
|
|
Assignee | |
Comment 1•10 years ago
|
||
|
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8483987 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23699 Changes: * reorder code to be defined prior to being used * update some brackets per style guide * classList.add supports multiple args so convert to that Ran tests locally, confirmed passed. Waiting on try server results.
Attachment #8483987 -
Flags: review?(arthur.chen)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8483987 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23699 Thanks for the patch! r=me.
Attachment #8483987 -
Flags: review?(arthur.chen) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
Thanks for the quick review Arthur, merged! 11:18 < gertrude> autonome pushed to master branch. Commits: http://bit.ly/Wi9h8M Results: http://mzl.la/Wi9h8P
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•