1062549 - Lockscreen slider should not paint after unlocking

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Benoit Girard (:BenWa)]

STR:
1) Lock phone
2) Unlock the phone using a swipe

The lockscreen lock slider repaints in the neutral position. This happens during the unlock animation and delays lock animation.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

The cause of this bug is because we simply setTimeout(400) and reset the handle w/o waiting for the animation to complete.

https://github.com/mozilla-b2g/gaia/blob/master/shared/js/lockscreen_slide.js#L595-L597

:snowmantw, what kind of event we can listen to here (or any new API we should add to LockScreenHandle) to make sure we only resets the handle after the animation?

I can certainly help :)

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

https://github.com/mozilla-b2g/gaia/blob/fe8298a40dbd/shared/js/lockscreen_slide.js#L595-L597

(in case the file changed later)

Comment 3

[Greg Weng [:snowmantw][:gweng][:λ]]

From a later offline discussion:

1. LockScreenSlider should add a method called 'reset' to correspond the 'start', 'stop' pattern in the current System.

2. The 'reset' method would reset the slider to the original state.

3. Component use the slider should control when to call the 'reset' method. In this case, when the visibility changed.

4. Principle is slider should not monitor too much things via itself. This should be done in LockScreenStateManager and implement LockScreenSlideShowState to command it to get reset.

Comment 4

[Mozilla Shepherd (This account is used for automation and doesn't receive bugmail)]

Attachment: mozilla-b2g:master PR#24370

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8494300 [details] [review]
mozilla-b2g:master PR#24370

After learned how state machine works in lock screen, I created this patch to introduce a new "slideHide" state so that we can transfer to "slideShow" state when lock screen is shown after unlocking. In the transferTo function, we would call lockScreenSlide.reset() to reset it's graphics.

There are some quirks in the lock screen inner working which I think we should address in follow-ups. First, There is only one function for each state when you transfer to it, and no function is called when transfer away from a state -- maybe having such API can help us writing lock screen code in a more DRY way.

Secondly, some of the unit test are invalid as there is no done() callback to wait for the then() function to call. We should address them too (and I should be more careful when doing review).

Comment 6

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8494300 [details] [review]
mozilla-b2g:master PR#24370

R+ with some nits. I think I need to open other bugs to fix the transferOut function.

Comment 7

[Greg Weng [:snowmantw][:gweng][:λ]]

Fired: Bug 1072143

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

master: https://github.com/mozilla-b2g/gaia/commit/18327379e6c58f8173721f43da211a995cc527cb