Closed Bug 1062552 Opened 6 years ago Closed 6 years ago

Use empty string as title if no title provided when adding a bookmark

Categories

(Firefox for Android :: Data Providers, defect)

All
Android
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 35
Tracking Status
firefox32 --- unaffected
firefox33 --- unaffected
firefox34 + verified
firefox35 --- verified
fennec 34+ ---

People

(Reporter: rnewman, Assigned: rnewman)

References

Details

Attachments

(1 file)

It turns out that Places barfs on null inputs.
Follow-up from this bug is to do on Android what we do on desktop: show the schema-less URL.
Depends on: 1061337
This should do the trick at the lowest possible level.
Attachment #8483760 - Flags: review?(chriskitching)
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
Attachment #8483760 - Flags: review?(chriskitching) → review+
https://hg.mozilla.org/mozilla-central/rev/ee1cfc2406f5
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Comment on attachment 8483760 [details] [diff] [review]
Use empty string as title if no title provided when adding a bookmark. v1

Approval Request Comment
[Feature/regressing bug #]:
  Brand-new share overlay work. See deps.

[User impact if declined]:
  User can semi-permanently break their Sync on desktop by bookmarking a page from Twitter.

[Describe test coverage new/current, TBPL]:
  None.

[Risks and why]: 
  Just about zero.

[String/UUID change made/needed]:
  None.
Attachment #8483760 - Flags: approval-mozilla-aurora?
Comment on attachment 8483760 [details] [diff] [review]
Use empty string as title if no title provided when adding a bookmark. v1

Aurora+
Attachment #8483760 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified as fixed on
Builds:
Firefox for Android 34 Beta 1
Firefox for Android 35.0a2 (2014-10-15)

Device: Asus Transformer Pad TF300T (Android 4.2.1)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.