Inline the activity options used in the dialer app in order to make it easier to automatically extract the activity arguments from the source code

RESOLVED FIXED in Firefox OS v2.2

Status

Firefox OS
Gaia::Dialer
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Away for a while, Assigned: Away for a while)

Tracking

(Blocks: 1 bug)

unspecified
2.1 S4 (12sep)
x86
Mac OS X

Firefox Tracking Flags

(b2g-v2.2 fixed)

Details

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
etienne
: review+
Details | Review | Splinter Review
(Assignee)

Description

3 years ago
I'm working on a static analysis tool which can extract information about all MozActivity API usages from the gaia source code.  It's much simper for this tool if the activity options argument was passed as an inline JS object.  I have a simple patch which does this for the dialer app.
(Assignee)

Updated

3 years ago
Blocks: 1016554
(Assignee)

Comment 1

3 years ago
Created attachment 8483763 [details] [review]
Patch (v1)
Attachment #8483763 - Flags: review?(etienne)
Comment on attachment 8483763 [details] [review]
Patch (v1)

That'll teach me reading patches without reading the bug summary first :)
"But this doesn't change anything!"

Anyway, sure, r=me
Attachment #8483763 - Flags: review?(etienne) → review+
(Assignee)

Comment 3

3 years ago
Thanks, Etienne!  Sorry if the intention was not obvious.  :-)
Keywords: checkin-needed
Master: https://github.com/mozilla-b2g/gaia/commit/8df7141e5a7b3ec34d062068ea97f18cb33c2889
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-b2g-v2.2: --- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S4 (12sep)
(Assignee)

Updated

3 years ago
Blocks: 1063041
(Assignee)

Updated

3 years ago
No longer blocks: 1063041
You need to log in before you can comment on or make changes to this bug.