Closed Bug 1062564 Opened 9 years ago Closed 9 years ago

Inline the activity options used in the dialer app in order to make it easier to automatically extract the activity arguments from the source code

Categories

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Dialer
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.2 fixed)

Status:
RESOLVED FIXED
Milestone:
2.1 S4 (12sep)
Tracking Flags:
Tracking Status
b2g-v2.2 --- fixed

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

Attachments

(1 file)

Patch (v1)
46 bytes, text/x-github-pull-request
etienne
: review+
Details | Review 
I'm working on a static analysis tool which can extract information about all MozActivity API usages from the gaia source code.  It's much simper for this tool if the activity options argument was passed as an inline JS object.  I have a simple patch which does this for the dialer app.
Blocks: 1016554
Attached file Patch (v1) — 

        Attachment #8483763 -
        Flags: review?(etienne)

    
    

    
  
Comment on attachment 8483763 [details] [review]
Patch (v1)

That'll teach me reading patches without reading the bug summary first :)
"But this doesn't change anything!"

Anyway, sure, r=me

        Attachment #8483763 -
        Flags: review?(etienne) → review+

    
    

    
  
Thanks, Etienne!  Sorry if the intention was not obvious.  :-)
Keywords: checkin-needed

    
    

    
  
Master: https://github.com/mozilla-b2g/gaia/commit/8df7141e5a7b3ec34d062068ea97f18cb33c2889
Status: NEW → RESOLVED
Closed: 9 years ago

          status-b2g-v2.2:
          --- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S4 (12sep)

    
  
Blocks: 1063041

    
  
No longer blocks: 1063041

          You need to log in
          before you can comment on or make changes to this bug.