1062617 - DevTools: Style Editor Import button should Open a Dialog box which defaults to CSS files

Status: RESOLVED FIXED

(DevTools :: Style Editor, defect, P3)

Description

[sys.sgx]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:35.0) Gecko/20100101 Firefox/35.0
Build ID: 20140903072057

Steps to reproduce:

Open DevTools Style Editor, and then click on the Import button. The OS dialog box that opens, should be allowed by default to select only files with the extension of css.

Comment 1

[rceciliagm]

I am able to reproduce the bug reported above: the OS dialog box that opens lists all files, not only the ones with extension css.

Comment 2

[Eric Skoglund [:tephra]]

Attachment: Patch v1

First contribution to devtools. Seems like we called the wrong function here and should have called appendFilters instead of appendFilter.

Not sure who to tag to review this any help with that?

// Eric

Comment 3

[Patrick Brosset <:pbro>]

Thanks for your contribution Eric.
Not sure who knows the file picker API to review this change. I have never used it.
I think maybe Mike might know more about this.

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8747476 [details] [diff] [review]
Patch v1

Review of attachment 8747476 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to eric from comment #2)
> Created attachment 8747476 [details] [diff] [review]
> Patch v1
> 
> First contribution to devtools. Seems like we called the wrong function here
> and should have called appendFilters instead of appendFilter.
> 
> Not sure who to tag to review this any help with that?
> 
> // Eric

We should have called appendFilter instead of appendFilters, which is what your patch does.

Great work! It is much appreciated.

Comment 5

[Eric Skoglund [:tephra]]

(In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #4)
> Comment on attachment 8747476 [details] [diff] [review]
> Patch v1
> 
> Review of attachment 8747476 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> (In reply to eric from comment #2)
> > Created attachment 8747476 [details] [diff] [review]
> > Patch v1
> > 
> > First contribution to devtools. Seems like we called the wrong function here
> > and should have called appendFilters instead of appendFilter.
> > 
> > Not sure who to tag to review this any help with that?
> > 
> > // Eric
> 
> We should have called appendFilter instead of appendFilters, which is what
> your patch does.
> 
> Great work! It is much appreciated.

Thanks Michael!

It's been a while since my last contribution to firefox so correct me if I'm wrong.
This needs to get pushed to the try-server before adding the checkin needed flag right?

// Eric

Comment 6

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Yes, and to push to try you would need Level 1 Commit Access, but we normally wait for you to submit a few patches first.

Would you like me to push this to try?

Comment 7

[Eric Skoglund [:tephra]]

(In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #6)
> Yes, and to push to try you would need Level 1 Commit Access, but we
> normally wait for you to submit a few patches first.
> 
> Would you like me to push this to try?

Yeah that would be great thanks!

Comment 8

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6d68c28660e4

Comment 9

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

This passes on try, marking as checkin-needed.

Comment 10

[Eric Skoglund [:tephra]]

(In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #9)
> This passes on try, marking as checkin-needed.

Thanks Michael, had some work stuff over the weekend and haven't had time to
mark it yet!

Thanks for the help on this bug :)

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/3bc242e75155

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This originally had the wrong bug number (102617), I backed that out and relanded it with the right number in https://hg.mozilla.org/integration/fx-team/rev/3bc242e75155

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3bc242e75155

Comment 14

[Tanvir Rahman]

I have reproduced this bug with Nightly 35.0a1(2014-09-03) on Windows 10, 64 bit!

The Bug's fix is now verified on Beta 49.0b1.

Build ID 	20160802125918
User Agent 	Mozilla/5.0 (Windows NT 10.0; WOW64; rv:49.0) Gecko/20100101 Firefox/49.0

[bugday-20160803]