1062622 - Add function to empty Sanitizer.jsm catch()

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Brian Nicholson (:bnicholson)]

promise.catch() requires a function, so the following then() block is currently broken in Sanitizer.jsm.

Comment 1

[Brian Nicholson (:bnicholson)]

Attachment: Add empty catch handler in Sanitizer.jsm

Comment 2

[Wesley Johnston (:wesj)]

Comment on attachment 8483855 [details] [diff] [review]
Add empty catch handler in Sanitizer.jsm

Review of attachment 8483855 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/modules/Sanitizer.jsm
@@ +153,5 @@
>      history: {
>        clear: function ()
>        {
>          return Messaging.sendRequestForResult({ type: "Sanitize:ClearHistory" })
> +          .catch(() => {}) // Purge Gecko-side data even if request failed

We should probably log this. Cu.reportError?

Comment 3

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/integration/fx-team/rev/42e164ec81d3

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/42e164ec81d3