B2G NFC: typo for 'ESE' in HCI Event origin

RESOLVED FIXED in Firefox 34, Firefox OS v2.1

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: allstars.chh, Assigned: dgarnerlee)

Tracking

unspecified
2.1 S4 (12sep)
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(blocking-b2g:2.1+, firefox33 wontfix, firefox34 fixed, firefox35 fixed, b2g-v2.1 fixed, b2g-v2.2 fixed)

Details

Attachments

(1 attachment)

In Bug 979767 the origin of embedded SE is typed as 'ESE', but from GSMA spec [1], it is 'eSE'

[1] : http://www.gsma.com/newsroom/wp-content/uploads/2014/03/TS26v5-0.pdf
(Reporter)

Updated

4 years ago
Flags: needinfo?(dgarnerlee)
(Assignee)

Comment 1

4 years ago
Yes, we should change it, since it's a app developer/user facing string. There's also ASSD capitalization to figure out. SIM is probably fine.
Assignee: nobody → dgarnerlee
Flags: needinfo?(dgarnerlee)
(Assignee)

Comment 2

4 years ago
Created attachment 8486051 [details] [diff] [review]
B2G NFC: typo for 'ESE' in HCI Event origin
Attachment #8486051 - Flags: review?(allstars.chh)
(Assignee)

Comment 3

4 years ago
[Blocking Requested - why for this release]:
blocking-b2g: --- → 2.1?
(Assignee)

Comment 4

4 years ago
(In reply to Garner Lee from comment #3)
> [Blocking Requested - why for this release]:

This is a user facing string to determine the secure transaction message origin. However, it's not critical either (lower case the staring, then compare).
Status: NEW → ASSIGNED
(Reporter)

Updated

4 years ago
Attachment #8486051 - Flags: review?(allstars.chh) → review+
(Assignee)

Comment 5

4 years ago
Green (after re-running the failing tests): https://tbpl.mozilla.org/?tree=Try&rev=b07f1e2ca28e
Keywords: checkin-needed
triage: defect from 2.1 new feature
blocking-b2g: 2.1? → 2.1+
https://hg.mozilla.org/mozilla-central/rev/b1df0233c4e1
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S4 (12sep)
Please request Aurora approval on this when you get a chance.
status-b2g-v2.1: --- → affected
status-b2g-v2.2: --- → fixed
status-firefox33: --- → wontfix
status-firefox34: --- → affected
status-firefox35: --- → fixed
Flags: needinfo?(dgarnerlee)
(Assignee)

Comment 10

4 years ago
Comment on attachment 8486051 [details] [diff] [review]
B2G NFC: typo for 'ESE' in HCI Event origin

Approval Request Comment
[Feature/regressing bug #]: Bug 979767
[User impact if declined]:
Low/medium to developer.
[Describe test coverage new/current, TBPL]:
None yet, emulator support needed. Certified API only currently.
[Risks and why]:
The origin string helps applications determine how trustworthy or important the transaction message origin is.
[String/UUID change made/needed]:
None.
Attachment #8486051 - Flags: approval-mozilla-aurora?
Flags: needinfo?(dgarnerlee)

Updated

4 years ago
Attachment #8486051 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/6af5dcb5d66c
status-b2g-v2.1: affected → fixed
status-firefox34: affected → fixed
You need to log in before you can comment on or make changes to this bug.