Closed
Bug 1062672
Opened 10 years ago
Closed 10 years ago
B2G NFC: typo for 'ESE' in HCI Event origin
Categories
(Firefox OS Graveyard :: NFC, defect)
Tracking
(blocking-b2g:2.1+, firefox33 wontfix, firefox34 fixed, firefox35 fixed, b2g-v2.1 fixed, b2g-v2.2 fixed)
People
(Reporter: allstars.chh, Assigned: dgarnerlee)
References
Details
Attachments
(1 file)
924 bytes,
patch
|
allstars.chh
:
review+
bajaj
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
In Bug 979767 the origin of embedded SE is typed as 'ESE', but from GSMA spec [1], it is 'eSE' [1] : http://www.gsma.com/newsroom/wp-content/uploads/2014/03/TS26v5-0.pdf
Reporter | ||
Updated•10 years ago
|
Flags: needinfo?(dgarnerlee)
Assignee | ||
Comment 1•10 years ago
|
||
Yes, we should change it, since it's a app developer/user facing string. There's also ASSD capitalization to figure out. SIM is probably fine.
Assignee: nobody → dgarnerlee
Flags: needinfo?(dgarnerlee)
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8486051 -
Flags: review?(allstars.chh)
Assignee | ||
Comment 3•10 years ago
|
||
[Blocking Requested - why for this release]:
blocking-b2g: --- → 2.1?
Assignee | ||
Comment 4•10 years ago
|
||
(In reply to Garner Lee from comment #3) > [Blocking Requested - why for this release]: This is a user facing string to determine the secure transaction message origin. However, it's not critical either (lower case the staring, then compare).
Status: NEW → ASSIGNED
Reporter | ||
Updated•10 years ago
|
Attachment #8486051 -
Flags: review?(allstars.chh) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Green (after re-running the failing tests): https://tbpl.mozilla.org/?tree=Try&rev=b07f1e2ca28e
Keywords: checkin-needed
Comment 7•10 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/b1df0233c4e1
Keywords: checkin-needed
Comment 8•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b1df0233c4e1
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S4 (12sep)
Comment 9•10 years ago
|
||
Please request Aurora approval on this when you get a chance.
status-b2g-v2.1:
--- → affected
status-b2g-v2.2:
--- → fixed
status-firefox33:
--- → wontfix
status-firefox34:
--- → affected
status-firefox35:
--- → fixed
Flags: needinfo?(dgarnerlee)
Assignee | ||
Comment 10•10 years ago
|
||
Comment on attachment 8486051 [details] [diff] [review] B2G NFC: typo for 'ESE' in HCI Event origin Approval Request Comment [Feature/regressing bug #]: Bug 979767 [User impact if declined]: Low/medium to developer. [Describe test coverage new/current, TBPL]: None yet, emulator support needed. Certified API only currently. [Risks and why]: The origin string helps applications determine how trustworthy or important the transaction message origin is. [String/UUID change made/needed]: None.
Attachment #8486051 -
Flags: approval-mozilla-aurora?
Flags: needinfo?(dgarnerlee)
Updated•10 years ago
|
Attachment #8486051 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in
before you can comment on or make changes to this bug.
Description
•