Closed Bug 1062750 Opened 9 years ago Closed 9 years ago

Double border on main toolbar on Aero

Categories

(Thunderbird :: Theme, defect)

Product:
Thunderbird
Component:
Theme
Version:
31 Branch
Platform:
All
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird_esr3132+ fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
thunderbird_esr31 32+ fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

References

Details

(Keywords: regression, Whiteboard: Only land on ESR31)

Attachments

(2 files)

DoubleBorder.png
33.72 KB, image/png
Details
Bug1062750.patch
1.09 KB, patch
jsbruner
: review+
standard8
: approval-comm-esr31+
Details | Diff | Splinter Review
Attached image DoubleBorder.png — 
The backport from bug 1041211 to ESR31 missed the removal of a bottom-border rule.

This is only a issue on TB 31.1. TB 32+ is all okay.
Attached patch Bug1062750.patch — — Splinter Review 
Remove the bottom-border and add the box-shadow for the non-Aero themes.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8484031 - Flags: review?(josiah)
Blocks: 1041211
Attachment #8484031 - Flags: review?(josiah) → review+
Comment on attachment 8484031 [details] [diff] [review]
Bug1062750.patch

[Approval Request Comment]
Regression caused by (bug #): bug 1041211 not fully backported
User impact if declined: weird looking main toolbox
Testing completed (on c-c, etc.): c-c has this code with original patch
Risk to taking this patch (and alternatives if risky): low, only two lines CSS
Attachment #8484031 - Flags: approval-comm-esr31?
Whiteboard: Only land on ESR31
Attachment #8484031 - Flags: approval-comm-esr31? → approval-comm-esr31+
https://hg.mozilla.org/releases/comm-esr31/rev/c3b2499fc4c0
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-thunderbird_esr31: --- → fixed
tracking-thunderbird_esr31: --- → 32+
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.