Closed Bug 1062773 Opened 7 years ago Closed 7 years ago
Any Disconnect Error invalidates the report as expected by the dashboard
Here is the issue as seen in mozmill-dashboard: https://github.com/mozilla/mozmill-dashboard/issues/116 We decided to fix the underlying issue which is how mozmill creates the report when handling a disconnect. Affected code should be around here: https://github.com/mozilla/mozmill/blob/master/mozmill/mozmill/__init__.py#L525 Lets try to fix this ASAP to get this in mozmill 2.0.7 which is due shortly.
Not being able to check reports is clearly a no-go. So yes, lets get this into 2.0.7. Should be easy enough to get the fix by adding the missing properties.
I've taken how we construct the test object from the the disabled test part: https://github.com/mozilla/mozmill/blob/master/mozmill/mozmill/__init__.py#L416 See results in action: Without this patch: http://mozmill-crowd.blargon7.com/#/functional/report/12a8568e34c97b929089c7a61fe107b4 With this patch: http://mozmill-crowd.blargon7.com/#/functional/report/12a8568e34c97b929089c7a61fe02ec0
Attachment #8484077 - Flags: review?(hskupin)
Comment on attachment 8484077 [details] [diff] [review] 0001-Bug-1062773-Fixed-the-reported-test-object-when-the-.patch Review of attachment 8484077 [details] [diff] [review]: ----------------------------------------------------------------- That looks fine to me. Thanks for the report links. I will get this landed in a bit.
Attachment #8484077 - Flags: review?(hskupin) → review+
https://github.com/mozilla/mozmill/commit/ac7f4ac25ed12112356a8d8e3744d0dad1e18706 (master) Andrei, can you please test on hotfix-2.0? If that also works I will cherry-pick it for that branch.
Applies on hotfix-2.0, and works as expected: http://mozmill-crowd.blargon7.com/#/functional/report/12a8568e34c97b929089c7a61fe4207b
Great. Landed on hotfix-2.0 too: https://github.com/mozilla/mozmill/commit/9885521a97ea0dbd548cce114ed02bcfd9dcc5c0
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.