Closed Bug 1062773 Opened 7 years ago Closed 7 years ago

Any Disconnect Error invalidates the report as expected by the dashboard

Categories

(Testing Graveyard :: Mozmill, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: andrei, Assigned: andrei)

References

Details

(Whiteboard: [mozmill-2.0.7+])

Attachments

(1 file)

Here is the issue as seen in mozmill-dashboard:
https://github.com/mozilla/mozmill-dashboard/issues/116

We decided to fix the underlying issue which is how mozmill creates the report when handling a disconnect.

Affected code should be around here:
https://github.com/mozilla/mozmill/blob/master/mozmill/mozmill/__init__.py#L525

Lets try to fix this ASAP to get this in mozmill 2.0.7 which is due shortly.
Not being able to check reports is clearly a no-go. So yes, lets get this into 2.0.7. Should be easy enough to get the fix by adding the missing properties.
Whiteboard: [mozmill-2.0.7+]
Comment on attachment 8484077 [details] [diff] [review]
0001-Bug-1062773-Fixed-the-reported-test-object-when-the-.patch

Review of attachment 8484077 [details] [diff] [review]:
-----------------------------------------------------------------

That looks fine to me. Thanks for the report links. I will get this landed in a bit.
Attachment #8484077 - Flags: review?(hskupin) → review+
https://github.com/mozilla/mozmill/commit/ac7f4ac25ed12112356a8d8e3744d0dad1e18706 (master)

Andrei, can you please test on hotfix-2.0? If that also works I will cherry-pick it for that branch.
Great. Landed on hotfix-2.0 too:
https://github.com/mozilla/mozmill/commit/9885521a97ea0dbd548cce114ed02bcfd9dcc5c0
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.