Closed
Bug 1062845
Opened 10 years ago
Closed 10 years ago
Done button when picking a song in Ringtones manager is hardcoded
Categories
(Firefox OS Graveyard :: Gaia::Music, defect)
Tracking
(b2g-v2.1 verified, b2g-v2.2 verified)
VERIFIED
FIXED
2.1 S4 (12sep)
People
(Reporter: theo, Assigned: theo)
Details
Attachments
(3 files)
Sorry, another one :/ STR: Switch to Accented English Open settings Go to Sound Go to Manage sounds Tap on "+" button Tap on one of your tracks Actual result: "Done" is in English Expected result: "Done" is localized [Blocking Requested - why for this release]: Unlocalized string
Assignee | ||
Comment 1•10 years ago
|
||
Dumb PR, tested on devices, the string is localized (we already have the done string)
Comment 2•10 years ago
|
||
Comment on attachment 8484149 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23720 Stealing review. rs=me
Attachment #8484149 -
Flags: review?(dkuo) → review+
Comment 4•10 years ago
|
||
Theo, Thanks for fixing! Once the fix lands on master. Ask Bhavana or Fabrice for 2.1 uplift approval for the patch. Setting target to sprint 4 (12 sep) Thanks Hema
blocking-b2g: 2.1? → ---
Target Milestone: --- → 2.1 S4 (12sep)
Comment 5•10 years ago
|
||
master : https://github.com/mozilla-b2g/gaia/commit/bbec78c592e1bbc5c4c20be264073c541f93271e
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 8484149 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23720 [Approval Request Comment] [Bug caused by] (feature/regressing bug #): -/- [User impact] if declined: English string displayed when picking a ringtone [Testing completed]: 2.2 device [Risk to taking this patch] (and alternatives if risky): very low [String changes made]: none
Attachment #8484149 -
Flags: approval-gaia-v2.1?(fabrice)
Updated•10 years ago
|
Attachment #8484149 -
Flags: approval-gaia-v2.1?(fabrice) → approval-gaia-v2.1+
Comment 7•10 years ago
|
||
v2.1: https://github.com/mozilla-b2g/gaia/commit/e0cc0dddf74aa1b7134a1a3babf0aeb270d91cb2
Hi Théo, If the device have no Accented English, May I use other language instead? Thanks!
Flags: needinfo?(tchevalier)
Comment 9•10 years ago
|
||
Yes. Anyhow, you have accented English, just go in Developer Settings and check the flag to enable pseudolocalizations, then you'll find it in the list of available languages.
Flags: needinfo?(tchevalier)
Comment 10•9 years ago
|
||
This issue has been verified successfully on Flame2.1&2.2 Verify video:"verify_1062845.mp4". Flame2.1 build: Gaia-Rev ccb49abe412c978a4045f0c75abff534372716c4 Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22 Build-ID 20141202001201 Version 34.0 Device-Name flame FW-Release 4.4.2 FW-Incremental eng.cltbld.20141202.034824 FW-Date Tue Dec 2 03:48:34 EST 2014 Bootloader L1TC00011880 Flame2.2 bulid: Gaia-Rev 725685831f5336cf007e36d9a812aad689604695 Gecko-Rev https://hg.mozilla.org/mozilla-central/rev/2c9781c3e9b5 Build-ID 20141202040207 Version 37.0a1 Device-Name flame FW-Release 4.4.2 FW-Incremental eng.cltbld.20141202.072347 FW-Date Tue Dec 2 07:23:58 EST 2014 Bootloader L1TC00011880
Comment 11•9 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•