1062890 - multil10n.py should not expect compare-locales hg repo to be called compare-locales

Status: RESOLVED WORKSFORME

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Pete Moore [:pmoore][:pete]]

tl;dr if you have a staging compare-locales repo, such as:
https://hg.mozilla.org/users/pmoore_mozilla.com/compare-locales-1040319
then multil10n.py won't be able to use it - it only works if the repo name is called compare-locales.

e.g. works:
https://hg.mozilla.org/users/pmoore_mozilla.com/compare-locales
fails:
https://hg.mozilla.org/users/pmoore_mozilla.com/compare-locales-1040319


Longer explanation
==================

When running android builds using a staging environment I set up for bug 1040319, I hit an issue whereby the release-mozilla-esr31-android-armv6_build builder failed, because my hg user repo of compare-locales was located under https://hg.mozilla.org/users/pmoore_mozilla.com/compare-locales-1040319. It could successfully hg clone this repo, but in the clone command it does not specify a DEST[1] directory name, so the local directory name of the clone is called compare-locales-1040319. However, multil10n.py assumes it is called compare-locales:
 
http://hg.mozilla.org/build/mozharness/file/ea52d732ef2f/mozharness/mozilla/l10n/locales.py#l145

This resulted in the error:

18:17:05     INFO -  python: can't open file '/builds/slave/rel-m-esr31-and-a6_bld-0000000/./compare-locales/scripts/compare-locales': [Errno 2] No such file or directory

as you see, it is looking for a directory called compare-locales, but on disk it was called:

/builds/slave/rel-m-esr31-and-a6_bld-0000000/compare-locales/scripts/compare-locales-1040319

Basically, it is the same bug as this one, in a different place: https://bugzilla.mozilla.org/show_bug.cgi?id=968195#c1

1) http://selenic.com/hg/help/clone

Comment 1

[Axel Hecht [:Pike]]

All mozharness calls go into the in-tree version of compare-locales now, so this bug is WORKSFORME.